code review 8637049: net: simplify socket option helpers

net: simplify socket option helpers

Also consolidates syscall.IPPROTO_TCP level option helper files.

[mikio, 2013-07-27 02:41:14]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-07-27 12:19:24]

LGTM. I cannot test the change to sockiptip_windows but I trust that you have
done so.

https://codereview.appspot.com/8637049/diff/40001/src/pkg/net/sockoptip_windo...
File src/pkg/net/sockoptip_windows.go (right):

https://codereview.appspot.com/8637049/diff/40001/src/pkg/net/sockoptip_windo...
src/pkg/net/sockoptip_windows.go:32: return os.NewSyscallError("setsockopt",
syscall.SetsockoptInt(fd.sysfd, syscall.IPPROTO_IP, syscall.IP_MULTICAST_LOOP,
boolint(v)))
not sure about this one, i don't have a windows machine to check.

https://codereview.appspot.com/8637049/diff/40001/src/pkg/net/tcpsockopt_unix.go
File src/pkg/net/tcpsockopt_unix.go (right):

https://codereview.appspot.com/8637049/diff/40001/src/pkg/net/tcpsockopt_unix...
src/pkg/net/tcpsockopt_unix.go:3: // license that can be found in the LICENSE
file.
If this is a new file, please update the copyright date.

[mikio, 2013-07-28 02:18:13]

*** Submitted as https://code.google.com/p/go/source/detail?r=f0e11bcf7c1d ***

net: simplify socket option helpers

Also consolidates syscall.IPPROTO_TCP level option helper files.

R=golang-dev, dave, alex.brainman
CC=golang-dev
https://codereview.appspot.com/8637049

[brainman, 2013-07-28 07:58:33]

LGTM