Issue 86360043: Fix reported arch on arm64 machines

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 86360043: Fix reported arch on arm64 machines (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 1 month ago by wallyworld

Modified:
10 years, 1 month ago

Reviewers:
thumper, mp+215074

Visibility:
Public.

Description

Fix reported arch on arm64 machines There was an error in NormaliseArch() which caused the architecture on arm64 machines to be misreported as armhf https://code.launchpad.net/~wallyworld/juju-core/fix-reported-arch-arm64/+merge/215074 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	juju/arch/arch.go	View	1 chunk	+1 line, -1 line	2 comments	Download
M	juju/arch/arch_test.go	View	1 chunk	+1 line, -0 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

thumper

https://codereview.appspot.com/86360043/diff/1/juju/arch/arch.go File juju/arch/arch.go (left): https://codereview.appspot.com/86360043/diff/1/juju/arch/arch.go#oldcode39 juju/arch/arch.go:39: {regexp.MustCompile("aarch64"), ARM64}, does this line need to be "aarch64|arm64" ...

10 years, 1 month ago (2014-04-10 10:49:31 UTC) #2

wallyworld

10 years, 1 month ago (2014-04-10 13:12:08 UTC) #3

This is landed since Dave approved the LP mp.

Expand All Messages | Collapse All Messages