Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2735)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 8632052: oauth issue 73: call to setScopes(String...) with null result in NullPointerException (API) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by peleyal
Modified:
11 years ago
Reviewers:
yanivi
CC:
ngmiceli
Base URL:
https://code.google.com/p/google-api-java-client/
Visibility:
Public.

Description

[default + 1.15] oauth issue 73: call to setScopes(String...) with null result in NullPointerException based on https://codereview.appspot.com/8865045/

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : minor #

Patch Set 4 : minor #

Patch Set 5 : change setScopes to get Collection<string> #

Patch Set 6 : minor #

Patch Set 7 : minor #

Patch Set 8 : minor #

Patch Set 9 : change refreshListeners to Collection #

Total comments: 14

Patch Set 10 : Yanivi comments #

Total comments: 2

Patch Set 11 : remove setRefreshListener(List) #

Patch Set 12 : hg pull -u #

Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -47 lines) Patch
M clirr-ignored-differences.xml View 1 2 3 4 5 1 chunk +13 lines, -1 line 0 comments Download
M google-api-client-android/src/main/java/com/google/api/client/googleapis/extensions/android/gms/auth/GoogleAccountCredential.java View 1 2 3 4 5 4 chunks +23 lines, -1 line 0 comments Download
M google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredential.java View 1 2 3 4 5 6 7 8 9 5 chunks +56 lines, -4 lines 0 comments Download
M google-api-client-appengine/src/test/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredentialTest.java View 1 2 3 4 2 chunks +8 lines, -5 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleAuthorizationCodeFlow.java View 1 2 3 4 5 6 7 8 9 10 11 8 chunks +88 lines, -6 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleAuthorizationCodeRequestUrl.java View 1 2 3 4 3 chunks +100 lines, -8 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleAuthorizationCodeTokenRequest.java View 1 2 3 4 2 chunks +11 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleBrowserClientRequestUrl.java View 1 2 3 4 5 6 7 5 chunks +70 lines, -1 line 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredential.java View 1 2 3 4 5 6 7 8 9 14 chunks +68 lines, -18 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/GoogleRefreshTokenRequest.java View 1 2 3 4 2 chunks +11 lines, -0 lines 0 comments Download
M google-api-client/src/main/java/com/google/api/client/googleapis/compute/ComputeCredential.java View 1 2 3 4 5 6 7 8 10 2 chunks +2 lines, -2 lines 0 comments Download
M google-api-client/src/test/java/com/google/api/client/googleapis/auth/oauth2/GoogleCredentialTest.java View 3 5 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 7
peleyal
11 years ago (2013-04-23 21:54:41 UTC) #1
peleyal
refresh listeners was changed to Collection
11 years ago (2013-04-30 17:16:48 UTC) #2
yanivi
https://codereview.appspot.com/8632052/diff/35001/google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredential.java File google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredential.java (right): https://codereview.appspot.com/8632052/diff/35001/google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredential.java#newcode72 google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredential.java:72: public AppIdentityCredential(Collection<String> scopes) { @since 1.15 https://codereview.appspot.com/8632052/diff/35001/google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredential.java#newcode175 google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredential.java:175: */ ...
11 years ago (2013-05-01 15:52:03 UTC) #3
peleyal
https://codereview.appspot.com/8632052/diff/35001/google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredential.java File google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredential.java (right): https://codereview.appspot.com/8632052/diff/35001/google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredential.java#newcode72 google-api-client-appengine/src/main/java/com/google/api/client/googleapis/extensions/appengine/auth/oauth2/AppIdentityCredential.java:72: public AppIdentityCredential(Collection<String> scopes) { On 2013/05/01 15:52:03, yanivi wrote: ...
11 years ago (2013-05-01 19:15:33 UTC) #4
yanivi
https://codereview.appspot.com/8632052/diff/53001/google-api-client/src/main/java/com/google/api/client/googleapis/compute/ComputeCredential.java File google-api-client/src/main/java/com/google/api/client/googleapis/compute/ComputeCredential.java (right): https://codereview.appspot.com/8632052/diff/53001/google-api-client/src/main/java/com/google/api/client/googleapis/compute/ComputeCredential.java#newcode167 google-api-client/src/main/java/com/google/api/client/googleapis/compute/ComputeCredential.java:167: public Builder setRefreshListeners(List<CredentialRefreshListener> refreshListeners) { remove this
11 years ago (2013-05-01 22:02:37 UTC) #5
peleyal
https://codereview.appspot.com/8632052/diff/53001/google-api-client/src/main/java/com/google/api/client/googleapis/compute/ComputeCredential.java File google-api-client/src/main/java/com/google/api/client/googleapis/compute/ComputeCredential.java (right): https://codereview.appspot.com/8632052/diff/53001/google-api-client/src/main/java/com/google/api/client/googleapis/compute/ComputeCredential.java#newcode167 google-api-client/src/main/java/com/google/api/client/googleapis/compute/ComputeCredential.java:167: public Builder setRefreshListeners(List<CredentialRefreshListener> refreshListeners) { On 2013/05/01 22:02:37, yanivi ...
11 years ago (2013-05-02 12:52:14 UTC) #6
yanivi
11 years ago (2013-05-02 13:33:35 UTC) #7 
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b