code review 8631047: test: make goprint.go wait longer for go its routine to...

test: make goprint.go wait longer for go its routine to execute

Update issue 5281

[cshapiro, 2013-04-12 22:49:19]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2013-04-12 22:51:13]

https://codereview.appspot.com/8631047/diff/9001/test/goprint.go
File test/goprint.go (right):

https://codereview.appspot.com/8631047/diff/9001/test/goprint.go#newcode15
test/goprint.go:15: time.Sleep(100e6)
time.Sleep(1*time.Second)

[bradfitz, 2013-04-12 22:57:49]

These tests are slow enough.  I don't think we need a full second.



On Fri, Apr 12, 2013 at 3:51 PM, <r@golang.org> wrote:

>
>
https://codereview.appspot.**com/8631047/diff/9001/test/**goprint.go<https://...
> File test/goprint.go (right):
>
> https://codereview.appspot.**com/8631047/diff/9001/test/**
>
goprint.go#newcode15<https://codereview.appspot.com/8631047/diff/9001/test/goprint.go#newcode15>
> test/goprint.go:15: time.Sleep(100e6)
> time.Sleep(1*time.Second)
>
>
https://codereview.appspot.**com/8631047/<https://codereview.appspot.com/8631...
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[cshapiro1, 2013-04-12 22:58:23]

PTAL

[r, 2013-04-12 23:00:43]

https://codereview.appspot.com/8631047/diff/14001/test/goprint.go
File test/goprint.go (right):

https://codereview.appspot.com/8631047/diff/14001/test/goprint.go#newcode15
test/goprint.go:15: time.Sleep(1*time.Second)
brad wants less time, so: 100*time.Millisecond please.

[bradfitz, 2013-04-12 23:00:48]

LGTM but all values suck here.

Too long and it makes test/run even slower.  Too short and it's flaky.




On Fri, Apr 12, 2013 at 3:58 PM, <cshapiro@google.com> wrote:

> PTAL
>
>
https://codereview.appspot.**com/8631047/<https://codereview.appspot.com/8631...
>

[bradfitz, 2013-04-12 23:01:18]

LGTM with 100 ms too.



On Fri, Apr 12, 2013 at 4:00 PM, <r@golang.org> wrote:

>
>
https://codereview.appspot.**com/8631047/diff/14001/test/**goprint.go<https:/...
> File test/goprint.go (right):
>
> https://codereview.appspot.**com/8631047/diff/14001/test/**
>
goprint.go#newcode15<https://codereview.appspot.com/8631047/diff/14001/test/goprint.go#newcode15>
> test/goprint.go:15: time.Sleep(1*time.Second)
> brad wants less time, so: 100*time.Millisecond please.
>
>
https://codereview.appspot.**com/8631047/<https://codereview.appspot.com/8631...
>

[r, 2013-04-12 23:01:33]

LGTM
go with 100ms

[cshapiro, 2013-04-12 23:04:27]

*** Submitted as https://code.google.com/p/go/source/detail?r=9c8d9728db93 ***

test: make goprint.go wait longer for go its routine to execute

Update issue 5281

R=golang-dev, r, bradfitz, cshapiro
CC=golang-dev
https://codereview.appspot.com/8631047