Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(771)

Issue 8630043: worker/machiner: set status and agent alive (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by dimitern
Modified:
8 years, 7 months ago
Reviewers:
mp+158162, fwereade, rog
Visibility:
Public.

Description

worker/machiner: set status and agent alive The machiner will now set the machine status as needed (started/stopped), log the actions with Noticef, and SetAgentAlive(), as required. https://code.launchpad.net/~dimitern/juju-core/030-machiner-sets-status/+merge/158162 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 6

Patch Set 2 : worker/machiner: set status and agent alive #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -0 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M worker/machiner/machiner.go View 1 3 chunks +24 lines, -0 lines 0 comments Download
M worker/machiner/machiner_test.go View 1 3 chunks +61 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dimitern
Please take a look.
8 years, 7 months ago (2013-04-10 16:19:52 UTC) #1
fwereade
LGTM modulo missing test https://codereview.appspot.com/8630043/diff/1/worker/machiner/machiner.go File worker/machiner/machiner.go (right): https://codereview.appspot.com/8630043/diff/1/worker/machiner/machiner.go#newcode59 worker/machiner/machiner.go:59: Reverse the order of these, ...
8 years, 7 months ago (2013-04-10 16:37:15 UTC) #2
rog
LGTM modulo william's comments. https://codereview.appspot.com/8630043/diff/1/worker/machiner/machiner.go File worker/machiner/machiner.go (right): https://codereview.appspot.com/8630043/diff/1/worker/machiner/machiner.go#newcode59 worker/machiner/machiner.go:59: On 2013/04/10 16:37:15, fwereade wrote: ...
8 years, 7 months ago (2013-04-11 07:49:08 UTC) #3
dimitern
8 years, 7 months ago (2013-04-11 09:11:59 UTC) #4
*** Submitted:

worker/machiner: set status and agent alive

The machiner will now set the machine status
as needed (started/stopped), log the actions
with Noticef, and SetAgentAlive(), as required.

R=fwereade, rog
CC=
https://codereview.appspot.com/8630043

https://codereview.appspot.com/8630043/diff/1/worker/machiner/machiner.go
File worker/machiner/machiner.go (right):

https://codereview.appspot.com/8630043/diff/1/worker/machiner/machiner.go#new...
worker/machiner/machiner.go:59: 
On 2013/04/10 16:37:15, fwereade wrote:
> Reverse the order of these, I think

Done.

https://codereview.appspot.com/8630043/diff/1/worker/machiner/machiner_test.go
File worker/machiner/machiner_test.go (right):

https://codereview.appspot.com/8630043/diff/1/worker/machiner/machiner_test.g...
worker/machiner/machiner_test.go:76: s.waitMachineStatus(c, m,
params.MachineStarted)
On 2013/04/10 16:37:15, fwereade wrote:
> I don't see a test for AgentAlive here.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b