Issue 86300043: code review 86300043: text/template: say more often that templates are safe f...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 86300043: code review 86300043: text/template: say more often that templates are safe f... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by r

Modified:
11 years, 1 month ago

Reviewers:
crawshaw1

CC:
golang-codereviews, crawshaw1

Visibility:
Public.

Description

text/template: say more often that templates are safe for parallel execution It was said already but apparently not enough times. Fixes issue 6985.

Patch Set 2 : diff -r 4c6d48b65d66 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9d401d2d8f75 https://code.google.com/p/go/ #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
M	src/pkg/html/template/template.go	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/pkg/text/template/doc.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/text/template/exec.go	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 1 month ago (2014-04-10 00:48:53 UTC) #1

crawshaw1

LGTM https://codereview.appspot.com/86300043/diff/1/src/pkg/html/template/template.go File src/pkg/html/template/template.go (right): https://codereview.appspot.com/86300043/diff/1/src/pkg/html/template/template.go#newcode65 src/pkg/html/template/template.go:65: // Once parsed, a template may be executed ...

11 years, 1 month ago (2014-04-10 08:38:20 UTC) #2

11 years, 1 month ago (2014-04-15 15:48:44 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=ae48c492cd8d ***

text/template: say more often that templates are safe for parallel execution
It was said already but apparently not enough times.

Fixes issue 6985.

LGTM=crawshaw
R=golang-codereviews, crawshaw
CC=golang-codereviews
https://codereview.appspot.com/86300043

Expand All Messages | Collapse All Messages