Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(659)

Issue 8626044: state/api: enable authentication

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 7 months ago by rog
Modified:
8 years, 7 months ago
Reviewers:
mp+158170, dfc, fwereade
Visibility:
Public.

Description

state/api: enable authentication https://code.launchpad.net/~rogpeppe/juju-core/279-api-enable-auth/+merge/158170 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/api: enable authentication #

Patch Set 3 : state/api: enable authentication #

Total comments: 1

Patch Set 4 : state/api: enable authentication #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -20 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/jujud/bootstrap.go View 1 chunk +11 lines, -1 line 0 comments Download
M cmd/jujud/machine_test.go View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M state/apiserver/api_test.go View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M state/apiserver/apiserver.go View 1 2 3 2 chunks +0 lines, -9 lines 0 comments Download
M state/user.go View 1 chunk +10 lines, -3 lines 0 comments Download
M state/user_test.go View 1 2 chunks +12 lines, -0 lines 0 comments Download
M testing/mgo.go View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6
rog
Please take a look.
8 years, 7 months ago (2013-04-10 17:20:32 UTC) #1
fwereade
LGTM
8 years, 7 months ago (2013-04-10 21:04:29 UTC) #2
dfc
LGTM with the general observation that this CL, and (without wanting to pick on him) ...
8 years, 7 months ago (2013-04-11 06:03:01 UTC) #3
rog
On 11 April 2013 07:03, <dave@cheney.net> wrote: > LGTM with the general observation that this ...
8 years, 7 months ago (2013-04-11 13:20:17 UTC) #4
rog
*** Submitted: state/api: enable authentication R=fwereade, dfc CC= https://codereview.appspot.com/8626044
8 years, 7 months ago (2013-04-11 14:09:38 UTC) #5
dfc
8 years, 7 months ago (2013-04-11 23:54:37 UTC) #6
>> If so, could the initial password be made some random string ?
>
>
> I would prefer to fix this problem at its root - currently we carry on
> executing
> the cloudinit  script even when the init script has failed.
>
> If we fix that behaviour, then I don't think the above is an issue.

I think there is another source of error, there are three method calls
which return an error inside that method, the first may succeed,
creating the user Admin, with the password "", but if the second
fails, the account will remain with a password of "".
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b