Issue 8625043: code review 8625043: cmd/ld: fix scope of static objects in symbol table

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8625043: code review 8625043: cmd/ld: fix scope of static objects in symbol table (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by ality

Modified:
12 years ago

Reviewers:

CC:
golang-dev, iant, r

Visibility:
Public.

Description

cmd/ld: fix scope of static objects in symbol table All symbols are currently marked with global scope. The correct behavior was lost when the symbol table format was changed.

Patch Set 1 #

Patch Set 2 : diff -r b27b1ff18f39 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b27b1ff18f39 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 522c34c6fe61 https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/ld/symtab.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ality

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-04-10 14:03:40 UTC) #1

iant

LGTM I think this is appropriate for Go 1.1, as it fixes a bug in ...

12 years ago (2013-04-10 19:49:06 UTC) #2

ality

12 years ago (2013-04-11 01:48:10 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=c479e6a12c69 ***

cmd/ld: fix scope of static objects in symbol table

All symbols are currently marked with global scope.
The correct behavior was lost when the symbol table
format was changed.

R=golang-dev, iant, r
CC=golang-dev
https://codereview.appspot.com/8625043

Expand All Messages | Collapse All Messages