Add destroy_service to the Go environment.

Add destroy_service to the Go environment.

Add destroy_service to the Go environment, with tests.

Remove handleSetConfig from the Go environment: it is the same
as handleServiceCalls, used in its place.

Add tests for destroy_service to the Python environment too.

Increase the timeout in the test's index.html, to make debug tests
pass on my slow machine.

https://code.launchpad.net/~teknico/juju-gui/add-destroy-service-to-go-env/+merge/158063

(do not edit description out of merge proposal)

[teknico, 2013-04-10 12:02:30]

Please take a look.

[frankban, 2013-04-10 13:25:59]

LGTM after adding the test mentioned below. Thank you!

https://codereview.appspot.com/8618043/diff/1/test/test_env_go.js
File test/test_env_go.js (right):

https://codereview.appspot.com/8618043/diff/1/test/test_env_go.js#newcode700
test/test_env_go.js:700: RequestId: msg.RequestId,
I believe msg.RequestId is undefined here.

https://codereview.appspot.com/8618043/diff/1/test/test_env_go.js#newcode706
test/test_env_go.js:706: 
Please add a test for a successful ServiceDestroy call.

[bac, 2013-04-10 13:34:21]

LGTM with the one change requested by Francesco.  (I think the other was
mistaken.)

https://codereview.appspot.com/8618043/diff/1/app/store/env/go.js
File app/store/env/go.js (left):

https://codereview.appspot.com/8618043/diff/1/app/store/env/go.js#oldcode666
app/store/env/go.js:666: handleSetConfig: function(userCallback, serviceName,
data) {
Thanks for recognizing the redundancy.

https://codereview.appspot.com/8618043/diff/1/test/test_env_go.js
File test/test_env_go.js (right):

https://codereview.appspot.com/8618043/diff/1/test/test_env_go.js#newcode679
test/test_env_go.js:679: it('can destroy a service', function() {
Isn't this the test for successful destroy?

https://codereview.appspot.com/8618043/diff/1/test/test_env_go.js#newcode700
test/test_env_go.js:700: RequestId: msg.RequestId,
Even worse, msg isn't defined.

[frankban, 2013-04-10 13:39:12]

https://codereview.appspot.com/8618043/diff/1/test/test_env_go.js
File test/test_env_go.js (right):

https://codereview.appspot.com/8618043/diff/1/test/test_env_go.js#newcode679
test/test_env_go.js:679: it('can destroy a service', function() {
On 2013/04/10 13:34:21, bac wrote:
> Isn't this the test for successful destroy?

No it is not. AFAICT, this just checks that we are going to senf the expected
message to the server when we call env.destroy_service. I was suggesting to add
a test for when the server replies with a successful response.

[teknico, 2013-04-10 15:13:21]

Made changes as asked, landing.

https://codereview.appspot.com/8618043/diff/1/test/test_env_go.js
File test/test_env_go.js (right):

https://codereview.appspot.com/8618043/diff/1/test/test_env_go.js#newcode700
test/test_env_go.js:700: RequestId: msg.RequestId,
bac wrote:
> Even worse, msg isn't defined.

Indeed. Added, thanks.

https://codereview.appspot.com/8618043/diff/1/test/test_env_go.js#newcode706
test/test_env_go.js:706: 
frankban wrote:
> Please add a test for a successful ServiceDestroy call.

Done.

[teknico, 2013-04-10 15:18:03]

*** Submitted:

Add destroy_service to the Go environment.

Add destroy_service to the Go environment, with tests.

Remove handleSetConfig from the Go environment: it is the same
as handleServiceCalls, used in its place.

Add tests for destroy_service to the Python environment too.

Increase the timeout in the test's index.html, to make debug tests
pass on my slow machine.

R=frankban, bac
CC=
https://codereview.appspot.com/8618043