Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(503)

Issue 86160043: Error msg for local charm deploy missing series.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by cmars
Modified:
6 years, 5 months ago
Reviewers:
curtis, mp+215021, thumper
Visibility:
Public.

Description

Error msg for local charm deploy missing series. Add error message when unable to resolve series for local repository. Update juju deploy doc message to describe behavior. https://code.launchpad.net/~cmars/juju-core/local-repo-errmsg/+merge/215021 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Error msg for local charm deploy missing series. #

Patch Set 3 : Error msg for local charm deploy missing series. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M cmd/juju/common.go View 2 chunks +8 lines, -0 lines 0 comments Download
M cmd/juju/deploy.go View 1 2 chunks +7 lines, -5 lines 1 comment Download
M provider/local/environprovider.go View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6
cmars
Please take a look.
6 years, 5 months ago (2014-04-09 19:42:45 UTC) #1
curtis
Hi Casey. I am not a reviewer, just an interested party. https://codereview.appspot.com/86160043/diff/1/cmd/juju/deploy.go File cmd/juju/deploy.go (right): ...
6 years, 5 months ago (2014-04-09 20:13:32 UTC) #2
cmars
Please take a look. https://codereview.appspot.com/86160043/diff/1/cmd/juju/deploy.go File cmd/juju/deploy.go (right): https://codereview.appspot.com/86160043/diff/1/cmd/juju/deploy.go#newcode55 cmd/juju/deploy.go:55: However, for local charms, such ...
6 years, 5 months ago (2014-04-09 20:39:15 UTC) #3
cmars
Updated 'juju deploy' doc, what do you think?
6 years, 5 months ago (2014-04-09 20:43:32 UTC) #4
cmars
Please take a look.
6 years, 5 months ago (2014-04-09 21:08:01 UTC) #5
thumper
6 years, 5 months ago (2014-04-09 22:23:24 UTC) #6
LGTM 

perhaps an example in the help doc?

https://codereview.appspot.com/86160043/diff/40001/cmd/juju/deploy.go
File cmd/juju/deploy.go (right):

https://codereview.appspot.com/86160043/diff/40001/cmd/juju/deploy.go#newcode58
cmd/juju/deploy.go:58: environment, one must specify the series.
Worthwhile adding an example here?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b