Code review - Issue 86160043: Error msg for local charm deploy missing series.https://codereview.appspot.com/2014-04-09T22:23:24+00:00rietveld
Message from unknown
2014-04-09T19:42:39+00:00cmarsurn:md5:2896b139262d347bcaf27b23093fd557
Message from casey.marshall@gmail.com
2014-04-09T19:42:45+00:00cmarsurn:md5:f3900b5d29f960b0b2003565bac508bc
Please take a look.
Message from curtis@canonical.com
2014-04-09T20:13:32+00:00curtisurn:md5:3eb26327b3f49993bab32977c3dd1031
Hi Casey.
I am not a reviewer, just an interested party.
https://codereview.appspot.com/86160043/diff/1/cmd/juju/deploy.go
File cmd/juju/deploy.go (right):
https://codereview.appspot.com/86160043/diff/1/cmd/juju/deploy.go#newcode55
cmd/juju/deploy.go:55: However, for local charms, such as local:precise/mysql, one must specify the
I see "assuming a current default series of" in the text above. That is ambiguous. I din't know if that means the charm's default series or the environment's default-series.
Maybe this phrasing is helpful
However, for local charms, where the default-series is not specified in the environment, one must specify the series.
Older versions of juju had default-series in the env template created by "juju init". Many of my envs have a define default-series because juju put it there. So new local users of the past few months are the common victims of this change. Maybe the local template should a default-series line commented out to help users discover the feature.
Message from unknown
2014-04-09T20:39:13+00:00cmarsurn:md5:9d2c8bedf8acd3f04690452e2526048b
Message from casey.marshall@gmail.com
2014-04-09T20:39:15+00:00cmarsurn:md5:224aa0452c9f07f2fc691b3a3198ff8d
Please take a look.
https://codereview.appspot.com/86160043/diff/1/cmd/juju/deploy.go
File cmd/juju/deploy.go (right):
https://codereview.appspot.com/86160043/diff/1/cmd/juju/deploy.go#newcode55
cmd/juju/deploy.go:55: However, for local charms, such as local:precise/mysql, one must specify the
On 2014/04/09 20:13:33, curtis wrote:
> I see "assuming a current default series of" in the text above. That is
> ambiguous. I din't know if that means the charm's default series or the
> environment's default-series.
>
Added a sentence to disambiguate.
> Maybe this phrasing is helpful
> However, for local charms, where the default-series is not specified in the
> environment, one must specify the series.
>
Done.
> Older versions of juju had default-series in the env template created by "juju
> init". Many of my envs have a define default-series because juju put it there.
> So new local users of the past few months are the common victims of this change.
> Maybe the local template should a default-series line commented out to help
> users discover the feature.
Where does this template live? I see the templates for specific providers, but none of them contain a commented default-series: as far as I can tell.
My environment.yaml has a commented default-series, but it was generated ages ago.
Message from casey.marshall@gmail.com
2014-04-09T20:43:32+00:00cmarsurn:md5:77a949e739d3099b0fa74987f515ca90
Updated 'juju deploy' doc, what do you think?
Message from unknown
2014-04-09T21:07:59+00:00cmarsurn:md5:80bebbcc1a26f9e0fa90dc37c4a1a77b
Message from casey.marshall@gmail.com
2014-04-09T21:08:01+00:00cmarsurn:md5:a0d16bee2f909dd41d961cd92f03dfc2
Please take a look.
Message from tim.penhey@canonical.com
2014-04-09T22:23:24+00:00thumperurn:md5:5492ba776b9d7633607edf7a31bff375
LGTM
perhaps an example in the help doc?
https://codereview.appspot.com/86160043/diff/40001/cmd/juju/deploy.go
File cmd/juju/deploy.go (right):
https://codereview.appspot.com/86160043/diff/40001/cmd/juju/deploy.go#newcode58
cmd/juju/deploy.go:58: environment, one must specify the series.
Worthwhile adding an example here?