Issue 8615046: Add missing intrin.h include for __cpuid.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8615046: Add missing intrin.h include for __cpuid.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by Net147

Modified:
10 years, 11 months ago

Reviewers:
shannon.woods, dgkoch, Shannon Woods

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/branches/dx11proto/

Visibility:
Public.

More Reviews

Description

Add missing intrin.h include for __cpuid. libEGL/Display.cpp includes libGLESv2/mathutil.h. Usually intrin.h is included via libGLESv2/precompiled.h but libEGL doesn't use libGLESv2/precompiled.h.

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/libGLESv2/mathutil.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

shannon.woods_transgaming.com

Ah. I think it gets included via the STL container includes in the VS 2010 ...

11 years ago (2013-04-23 05:15:19 UTC) #2

Net147

On 2013/04/23 05:15:19, shannon.woods wrote: > Ah. I think it gets included via the STL ...

11 years ago (2013-04-23 08:52:32 UTC) #3

Shannon Woods

10 years, 11 months ago (2013-05-20 16:24:15 UTC) #4

On 2013/04/23 08:52:32, Net147 wrote:
> On 2013/04/23 05:15:19, shannon.woods wrote:
> > Ah. I think it gets included via the STL container includes in the VS 2010
> > implementation, and so it had escaped notice.
> > 
> > LGTM. I see you're already in AUTHORS and have signed the CLA, so I can land
> > this for you.
> 
> Please do.

Landed in r2241.

Expand All Messages | Collapse All Messages