Issue 8612051: Certificate writing respects JUJU_HOME

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8612051: Certificate writing respects JUJU_HOME

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by hazmat

Modified:
11 years ago

Reviewers:
mp+160423, TheMue

Visibility:
Public.

Description

Certificate writing respects JUJU_HOME Else JUJU_HOME was essentially broken, as certs would be written to ~/.juju but read from JUJU_HOME which meant any attempt to use an environment would fail with an error that the cert files couldn't be found/loaded. https://code.launchpad.net/~hazmat/juju-core/fix-juju-home/+merge/160423 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/cert.go	View	1 chunk	+6 lines, -1 line	0 comments	Download
M	environs/cert_test.go	View	2 chunks	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

hazmat

11 years ago (2013-04-23 22:25:19 UTC) #3

yeah.. much preferred on roger's solution.


On Tue, Apr 23, 2013 at 1:02 PM, <themue@gmail.com> wrote:

> NOT LGTM, so Rogers fix.
>
>
https://codereview.appspot.**com/8612051/<https://codereview.appspot.com/8612...
>

Expand All Messages | Collapse All Messages