Issue 86080043: cmd/jujud: call SetAPIHostPorts in tests

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 86080043: cmd/jujud: call SetAPIHostPorts in tests

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by rog

Modified:
10 years ago

Reviewers:
dimitern, mp+214971

Visibility:
Public.

Description

cmd/jujud: call SetAPIHostPorts in tests Without APIHostPorts set in state, the apiaddressupdater worker sets the API addresses in the agent configuration to an empty set very soon after the agent starts. The tests sometimes passed previously because APIWorker could grab the addresses before that happened. https://code.launchpad.net/~rogpeppe/juju-core/542-jujud-setapihostports-in-tests/+merge/214971 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : cmd/jujud: call SetAPIHostPorts in tests #

Total comments: 1

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -1 line)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/jujud/agent_test.go	View	4 chunks	+30 lines, -0 lines	1 comment	Download
M	state/api/apiclient.go	View	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

dimitern

10 years ago (2014-04-09 15:29:03 UTC) #2

LGTM with one comment. Nice catch!

https://codereview.appspot.com/86080043/diff/20001/cmd/jujud/agent_test.go
File cmd/jujud/agent_test.go (right):

https://codereview.appspot.com/86080043/diff/20001/cmd/jujud/agent_test.go#ne...
cmd/jujud/agent_test.go:286: addr, port, err := net.SplitHostPort(s)
How about:

nothing := instance.HostPort{}
then just return nothing, err on error.

IMO will read nicer.

Expand All Messages | Collapse All Messages