Issue 8607043: Fix environment annotations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8607043: Fix environment annotations

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by gary.poster

Modified:
11 years, 6 months ago

Reviewers:
mp+157977

Visibility:
Public.

Description

Fix environment annotations Environment annotations were being munged inappropriately, breaking our Landscape integration. This fixes that. Also, not all hyphens were being converted to underlines in delta attribute names, only the first one. This fixes that too. https://code.launchpad.net/~gary/juju-gui/landscape/+merge/157977 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix environment annotations #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -3 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/models/handlers.js	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	docs/process.rst	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	test/test_model_handlers.js	View	2 chunks	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

gary.poster

LGTM. Self-reviewing. It's beeeeeeeautiful! And a critical regression.

11 years, 6 months ago (2013-04-10 00:54:01 UTC) #2

gary.poster

11 years, 6 months ago (2013-04-10 00:57:43 UTC) #3

*** Submitted:

Fix environment annotations

Environment annotations were being munged inappropriately, breaking our
Landscape integration.  This fixes that.

Also, not all hyphens were being converted to underlines in delta attribute
names, only the first one.  This fixes that too.

R=
CC=
https://codereview.appspot.com/8607043

Expand All Messages | Collapse All Messages