Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(397)

Issue 86040043: code review 86040043: runtime: use 3x fewer nanotime calls in garbage collection (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 1 month ago by rsc
Modified:
11 years, 1 month ago
Reviewers:
iant
CC:
golang-codereviews, iant, 0intro, aram, khr
Visibility:
Public.

Description

runtime: use 3x fewer nanotime calls in garbage collection Cuts the number of calls from 6 to 2 in the non-debug case.

Patch Set 1 #

Patch Set 2 : diff -r b47cc57f5635 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b47cc57f5635 https://code.google.com/p/go/ #

Patch Set 4 : diff -r b47cc57f5635 https://code.google.com/p/go/ #

Patch Set 5 : diff -r b47cc57f5635 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M src/pkg/runtime/mgc0.c View 1 2 3 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-codereviews@googlegroups.com (cc: 0intro, aram@mgk.ro, khr), I'd like you to review this change to https://code.google.com/p/go/
11 years, 1 month ago (2014-04-09 14:30:13 UTC) #1
rsc
The debug print changing from MB to kB was not intended here. I've reverted that ...
11 years, 1 month ago (2014-04-09 14:34:42 UTC) #2
iant
LGTM
11 years, 1 month ago (2014-04-09 14:36:00 UTC) #3
rsc
11 years, 1 month ago (2014-04-09 14:38:14 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=29a6a4ac1164 ***

runtime: use 3x fewer nanotime calls in garbage collection

Cuts the number of calls from 6 to 2 in the non-debug case.

LGTM=iant
R=golang-codereviews, iant
CC=0intro, aram, golang-codereviews, khr
https://codereview.appspot.com/86040043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b