Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7637)

Issue 85970044: clone session in replicaset.Initiate

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years ago by natefinch
Modified:
10 years ago
Reviewers:
mp+214990, jameinel, rog
Visibility:
Public.

Description

clone session in replicaset.Initiate make sure we don't muck with the session that is passed into initiate and instead just clone it and muck with that one. https://code.launchpad.net/~natefinch/juju-core/040-clonesession/+merge/214990 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : clone session in replicaset.Initiate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M replicaset/replicaset.go View 1 1 chunk +4 lines, -4 lines 0 comments Download
M replicaset/replicaset_test.go View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4
natefinch
Please take a look.
10 years ago (2014-04-09 16:44:41 UTC) #1
natefinch
Please take a look.
10 years ago (2014-04-09 16:46:24 UTC) #2
rog
On 2014/04/09 16:46:24, nate.finch wrote: > Please take a look. LGTM
10 years ago (2014-04-09 17:02:47 UTC) #3
jameinel
10 years ago (2014-04-09 17:04:29 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b