Fix login called twice in some cases.

Fix login called twice in some cases.

Login was called twice in some cases. 
The first time by the connectedChange subscriber reacting to a
WebSocket connection/reconnection. The second time only if the 
credentials are available (stashed in the storage or just
provided in config) and the user is not authenticated.
AFAICT, the latter case is completely redundant, given
that the two conditions above are both true only
at the beginning of the auth process, started right
after the WebSocket is connected, so, reasonably, 
when the login is already attempted by the connectedChange
subscriber.

QA:

Try to login with or without setting user and password in
config. Refresh, logout, disconnect rapi-delta, reconnect,
hack!

https://code.launchpad.net/~frankban/juju-gui/login-again/+merge/160690

(do not edit description out of merge proposal)

[frankban, 2013-04-24 15:43:38]

Please take a look.

[jeff.pihach, 2013-04-24 16:36:26]

LGTM Thanks a lot for doing this fix!

https://codereview.appspot.com/8596048/diff/1/test/test_app.js
File test/test_app.js (right):

https://codereview.appspot.com/8596048/diff/1/test/test_app.js#newcode214
test/test_app.js:214: container.remove();
container.remove().destroy(true);
This will remove the element from the DOM, destroy the element, and remove all
event listeners on it.

[teknico, 2013-04-24 17:04:48]

LGTM, nice catch and comments, lots of tests, great job!

[frankban, 2013-04-24 17:16:38]

*** Submitted:

Fix login called twice in some cases.

Login was called twice in some cases. 
The first time by the connectedChange subscriber reacting to a
WebSocket connection/reconnection. The second time only if the 
credentials are available (stashed in the storage or just
provided in config) and the user is not authenticated.
AFAICT, the latter case is completely redundant, given
that the two conditions above are both true only
at the beginning of the auth process, started right
after the WebSocket is connected, so, reasonably, 
when the login is already attempted by the connectedChange
subscriber.

QA:

Try to login with or without setting user and password in
config. Refresh, logout, disconnect rapi-delta, reconnect,
hack!

R=jeff.pihach, teknico
CC=
https://codereview.appspot.com/8596048