http issue 200: use default usecaches value

http issue 200: use default usecaches value

[peleyal, 2013-04-09 18:30:46]

use the default value of usescaches (and not set it to false)

[yanivi, 2013-04-11 03:20:46]

Implementation seems fine.  The only issue I have is that this is technically a
backwards-incompatible change, so we should document this in the class-level
JavaDoc of NetHttpTransport in two ways.  First, we should document how to
customize the caching behavior using
http://docs.oracle.com/javase/7/docs/api/java/net/URLConnection.html#setDefau...
.  Second, we should document the change in behavior from 1.14 where caching was
always disabled, but now we honor the default global caching behavior.

[peleyal, 2013-04-11 18:33:23]

On 2013/04/11 03:20:46, yanivi wrote:
> Implementation seems fine.  The only issue I have is that this is technically
a
> backwards-incompatible change, so we should document this in the class-level
> JavaDoc of NetHttpTransport in two ways.  First, we should document how to
> customize the caching behavior using
>
http://docs.oracle.com/javase/7/docs/api/java/net/URLConnection.html#setDefau...)
> .  Second, we should document the change in behavior from 1.14 where caching
was
> always disabled, but now we honor the default global caching behavior.

Done. upgrade warning was added to the class-level JavaDoc

[yanivi, 2013-04-11 20:24:42]

https://codereview.appspot.com/8591043/diff/4001/google-http-client/src/main/...
File
google-http-client/src/main/java/com/google/api/client/http/javanet/NetHttpRequest.java
(right):

https://codereview.appspot.com/8591043/diff/4001/google-http-client/src/main/...
google-http-client/src/main/java/com/google/api/client/http/javanet/NetHttpRequest.java:26:
* <p>
this needs to go into the public class NetHttpTransport, not NetHttpRequest
because NetHttpRequest is package private.

https://codereview.appspot.com/8591043/diff/4001/google-http-client/src/main/...
google-http-client/src/main/java/com/google/api/client/http/javanet/NetHttpRequest.java:27:
* Upgrade warning: in prior version 1.14 caching was always disabled, but
starting with version
We need to split this into 2 sections.  Here's a rough example to demonstrate
the idea:

"
We honor the default global caching behavior. To change the default behavior use
{@link HttpURLConnection#setDefaultUseCaches(boolean)}.

Upgrade warning: in prior version 1.14 caching was always disabled, but starting
with version 1.15 we honor the default global caching behavior.
"

It may seem a bit redundant, but the idea is that in 1.16 we'll remove the
upgrade warning, and therefore we want some part of this to remain long-term.

[peleyal, 2013-04-11 20:46:09]

https://codereview.appspot.com/8591043/diff/4001/google-http-client/src/main/...
File
google-http-client/src/main/java/com/google/api/client/http/javanet/NetHttpRequest.java
(right):

https://codereview.appspot.com/8591043/diff/4001/google-http-client/src/main/...
google-http-client/src/main/java/com/google/api/client/http/javanet/NetHttpRequest.java:26:
* <p>
On 2013/04/11 20:24:42, yanivi wrote:
> this needs to go into the public class NetHttpTransport, not NetHttpRequest
> because NetHttpRequest is package private.

Done.

https://codereview.appspot.com/8591043/diff/4001/google-http-client/src/main/...
google-http-client/src/main/java/com/google/api/client/http/javanet/NetHttpRequest.java:27:
* Upgrade warning: in prior version 1.14 caching was always disabled, but
starting with version
On 2013/04/11 20:24:42, yanivi wrote:
> We need to split this into 2 sections.  Here's a rough example to demonstrate
> the idea:
> 
> "
> We honor the default global caching behavior. To change the default behavior
use
> {@link HttpURLConnection#setDefaultUseCaches(boolean)}.
> 
> Upgrade warning: in prior version 1.14 caching was always disabled, but
starting
> with version 1.15 we honor the default global caching behavior.
> "
> 
> It may seem a bit redundant, but the idea is that in 1.16 we'll remove the
> upgrade warning, and therefore we want some part of this to remain long-term.

Got you. Done.

[yanivi, 2013-04-11 21:07:15]

LGTM