Issue 8589050: Fix retry and resolved buttons never displayed

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8589050: Fix retry and resolved buttons never displayed

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by frankban

Modified:
11 years, 1 month ago

Reviewers:
bac, teknico, mp+158973

Visibility:
Public.

Description

Fix retry and resolved buttons never displayed When the GUI is connected to PyJuju, error states are represented by an agent state like "install-error". In juju-core this is just an "error", and the info about what went wrong can be found in the StatusInfo. This branch makes the GUI able to handle both cases, and as a consequence it shows the "retry" and "resolved" buttons in the unit detail view when required. https://code.launchpad.net/~frankban/juju-gui/bug-1169159-retry-resolved/+merge/158973 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix retry and resolved buttons never displayed #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -35 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/templates/unit.handlebars	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	app/views/unit.js	View		2 chunks	+4 lines, -6 lines	0 comments	Download
M	app/views/utils.js	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	test/test_utils.js	View		1 chunk	+41 lines, -19 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bac

On 2013/04/15 16:36:34, frankban wrote: > Please take a look. LGTM Francesco. Thanks.

11 years, 1 month ago (2013-04-15 20:19:06 UTC) #2

frankban

11 years, 1 month ago (2013-04-16 08:59:15 UTC) #5

*** Submitted:

Fix retry and resolved buttons never displayed

When the GUI is connected to PyJuju, error states are
represented by an agent state like "install-error".
In juju-core this is just an "error", and the info
about what went wrong can be found in the StatusInfo.
This branch makes the GUI able to handle both cases, and 
as a consequence it shows the "retry" and "resolved"
buttons in the unit detail view when required.

R=bac, teknico
CC=
https://codereview.appspot.com/8589050

Expand All Messages | Collapse All Messages