Issue 85890043: code review 85890043: cmd/gc: drop { } around single-line if-statement body

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 85890043: code review 85890043: cmd/gc: drop { } around single-line if-statement body (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by atom

Modified:
11 years, 1 month ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

cmd/gc: drop { } around single-line if-statement body

Patch Set 1 #

Patch Set 2 : diff -r 2a858c0830af https://code.google.com/p/go/ #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	src/cmd/gc/gen.c	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

atom

Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

11 years, 1 month ago (2014-04-09 06:47:41 UTC) #1

atom

*** Submitted as https://code.google.com/p/go/source/detail?r=c9562f79b140 *** cmd/gc: drop { } around single-line if-statement body LGTM=rsc R=rsc ...

11 years, 1 month ago (2014-04-09 13:39:38 UTC) #3

gobot

11 years, 1 month ago (2014-04-09 13:52:25 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the linux-386 builder.
See http://build.golang.org/log/283fb758723f222a7b47ea7cd56a5498880c9144

Expand All Messages | Collapse All Messages