Issue 8585043: charm: use functions for validation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8585043: charm: use functions for validation

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by niemeyer

Modified:
11 years ago

Reviewers:
Danilo, dimitern, mp+157924

Visibility:
Public.

Description

charm: use functions for validation https://code.launchpad.net/~niemeyer/juju-core/func-validators/+merge/157924 (do not edit description out of merge proposal)

Patch Set 2 : charm: use functions for validation #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -55 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	charm/url.go	View		4 chunks	+21 lines, -11 lines	0 comments	Download
M	charm/url_test.go	View	1	2 chunks	+42 lines, -43 lines	0 comments	Download
M	cmd/juju/bootstrap.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Danilo

LGTM with a tiny suggestion on variable naming. https://codereview.appspot.com/8585043/diff/1/charm/url_test.go File charm/url_test.go (left): https://codereview.appspot.com/8585043/diff/1/charm/url_test.go#oldcode121 charm/url_test.go:121: var ...

11 years ago (2013-04-09 18:16:37 UTC) #3

niemeyer

11 years ago (2013-04-09 18:28:48 UTC) #4

*** Submitted:

charm: use functions for validation

R=dimitern, danilo.segan
CC=
https://codereview.appspot.com/8585043

https://codereview.appspot.com/8585043/diff/1/charm/url_test.go
File charm/url_test.go (left):

https://codereview.appspot.com/8585043/diff/1/charm/url_test.go#oldcode121
charm/url_test.go:121: var validRegexpTests = []struct {
On 2013/04/09 18:16:37, danilo.segan wrote:
> It's probably worthwhile to rename this to validCheckerTests as well (unless I
> am missing something).

Indeed, thanks.

https://codereview.appspot.com/8585043/diff/1/charm/url_test.go#oldcode166
charm/url_test.go:166: for i, t := range validRegexpTests {
On 2013/04/09 18:16:37, danilo.segan wrote:
> See above.

Done.

Expand All Messages | Collapse All Messages