Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(816)

Issue 8583048: Agents play nice on run dir race.

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by hazmat
Modified:
9 years, 2 months ago
Reviewers:
bcsaller, mp+158980
Visibility:
Public.

Description

Agents play nice on run dir race. Previously a reboot of several agents could cause a race around the creation of the /var/run/juju dir, even with an existence check, instead just try/except and handle win or lose the race. https://code.launchpad.net/~hazmat/juju/var-run-mass-restart/+merge/158980 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Agents play nice on run dir race. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M juju/agents/base.py View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 3
hazmat
Please take a look.
9 years, 2 months ago (2013-04-15 17:23:48 UTC) #1
bcsaller
LGTM w/trivial https://codereview.appspot.com/8583048/diff/1/juju/agents/base.py File juju/agents/base.py (right): https://codereview.appspot.com/8583048/diff/1/juju/agents/base.py#newcode41 juju/agents/base.py:41: if e.errno != 17: Could you use ...
9 years, 2 months ago (2013-04-15 17:51:30 UTC) #2
hazmat
9 years, 2 months ago (2013-04-15 21:50:45 UTC) #3
*** Submitted:

Agents play nice on run dir race.

Previously a reboot of several agents could cause a race around
the creation of the /var/run/juju dir, even with an existence check,
instead just try/except and handle win or lose the race.

R=bcsaller
CC=
https://codereview.appspot.com/8583048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b