Issue 8583048: Agents play nice on run dir race.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8583048: Agents play nice on run dir race.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by hazmat

Modified:
11 years ago

Reviewers:
bcsaller, mp+158980

Visibility:
Public.

Description

Agents play nice on run dir race. Previously a reboot of several agents could cause a race around the creation of the /var/run/juju dir, even with an existence check, instead just try/except and handle win or lose the race. https://code.launchpad.net/~hazmat/juju/var-run-mass-restart/+merge/158980 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Agents play nice on run dir race. #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	juju/agents/base.py	View	1	2 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bcsaller

LGTM w/trivial https://codereview.appspot.com/8583048/diff/1/juju/agents/base.py File juju/agents/base.py (right): https://codereview.appspot.com/8583048/diff/1/juju/agents/base.py#newcode41 juju/agents/base.py:41: if e.errno != 17: Could you use ...

11 years ago (2013-04-15 17:51:30 UTC) #2

hazmat

11 years ago (2013-04-15 21:50:45 UTC) #3

*** Submitted:

Agents play nice on run dir race.

Previously a reboot of several agents could cause a race around
the creation of the /var/run/juju dir, even with an existence check,
instead just try/except and handle win or lose the race.

R=bcsaller
CC=
https://codereview.appspot.com/8583048

Expand All Messages | Collapse All Messages