code review 8583047: test/stress: start of a runtime stress program

test/stress: start of a runtime stress program

Runs forever, stressing the runtime in various ways.

It should never terminate.

[bradfitz, 2013-04-12 22:08:39]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2013-04-12 22:11:58]

seems like a good start, but please move it to /test/stress or something like
that

https://codereview.appspot.com/8583047/diff/5001/misc/runstress/maps.go
File misc/runstress/maps.go (right):

https://codereview.appspot.com/8583047/diff/5001/misc/runstress/maps.go#newcode1
misc/runstress/maps.go:1: package main
copyrights

[bradfitz, 2013-04-12 22:12:18]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-04-12 22:15:23]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

Please take another look.

[r, 2013-04-12 22:18:40]

https://codereview.appspot.com/8583047/diff/10001/test/stress/maps.go
File test/stress/maps.go (right):

https://codereview.appspot.com/8583047/diff/10001/test/stress/maps.go#newcode1
test/stress/maps.go:1: package main
copyright

https://codereview.appspot.com/8583047/diff/10001/test/stress/parsego.go
File test/stress/parsego.go (right):

https://codereview.appspot.com/8583047/diff/10001/test/stress/parsego.go#newc...
test/stress/parsego.go:38: // (use dirname instead of path because dirname is
clean; i.e. has no trailing '/')
"because it has no trailing '/'"

https://codereview.appspot.com/8583047/diff/10001/test/stress/runstress.go
File test/stress/runstress.go (right):

https://codereview.appspot.com/8583047/diff/10001/test/stress/runstress.go#ne...
test/stress/runstress.go:28: doParseGo = flag.Bool("parsego", true, "Stress
parsing Go (generates garbage)")
drop the caps on Stress for the flag strings

https://codereview.appspot.com/8583047/diff/10001/test/stress/runstress.go#ne...
test/stress/runstress.go:31: func vlog(a ...interface{}) {
call this Println or println and vet can check it

https://codereview.appspot.com/8583047/diff/10001/test/stress/runstress.go#ne...
test/stress/runstress.go:67: log.Fatalf("Status code = %d", res.StatusCode)
the Fatalfs should say which test caused the failure

[minux1, 2013-04-12 22:26:47]

https://codereview.appspot.com/8583047/diff/10001/test/stress/runstress.go
File test/stress/runstress.go (right):

https://codereview.appspot.com/8583047/diff/10001/test/stress/runstress.go#ne...
test/stress/runstress.go:84: cmd := exec.Command("/bin/sh", "-c",
fmt.Sprintf("echo %s; exit %d", wantOutput, exit))
for windows, you can use "%ComSpec%" "/c" "echo %s& exit %d"
// note, no space between "%s" and "&".

[bradfitz, 2013-04-15 18:20:34]

Hello golang-dev@googlegroups.com, r@golang.org, minux.ma@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[bradfitz, 2013-04-15 18:20:37]

PTAL

https://codereview.appspot.com/8583047/diff/10001/test/stress/maps.go
File test/stress/maps.go (right):

https://codereview.appspot.com/8583047/diff/10001/test/stress/maps.go#newcode1
test/stress/maps.go:1: package main
On 2013/04/12 22:18:40, r wrote:
> copyright

Done.

https://codereview.appspot.com/8583047/diff/10001/test/stress/parsego.go
File test/stress/parsego.go (right):

https://codereview.appspot.com/8583047/diff/10001/test/stress/parsego.go#newc...
test/stress/parsego.go:38: // (use dirname instead of path because dirname is
clean; i.e. has no trailing '/')
On 2013/04/12 22:18:40, r wrote:
> "because it has no trailing '/'"

Done. But I just copied this code from another test.

https://codereview.appspot.com/8583047/diff/10001/test/stress/runstress.go
File test/stress/runstress.go (right):

https://codereview.appspot.com/8583047/diff/10001/test/stress/runstress.go#ne...
test/stress/runstress.go:28: doParseGo = flag.Bool("parsego", true, "Stress
parsing Go (generates garbage)")
On 2013/04/12 22:18:40, r wrote:
> drop the caps on Stress for the flag strings

Done.

https://codereview.appspot.com/8583047/diff/10001/test/stress/runstress.go#ne...
test/stress/runstress.go:31: func vlog(a ...interface{}) {
On 2013/04/12 22:18:40, r wrote:
> call this Println or println and vet can check it

Done.

https://codereview.appspot.com/8583047/diff/10001/test/stress/runstress.go#ne...
test/stress/runstress.go:67: log.Fatalf("Status code = %d", res.StatusCode)
On 2013/04/12 22:18:40, r wrote:
> the Fatalfs should say which test caused the failure

Done.

https://codereview.appspot.com/8583047/diff/10001/test/stress/runstress.go#ne...
test/stress/runstress.go:84: cmd := exec.Command("/bin/sh", "-c",
fmt.Sprintf("echo %s; exit %d", wantOutput, exit))
On 2013/04/12 22:26:47, minux wrote:
> for windows, you can use "%ComSpec%" "/c" "echo %s& exit %d"
> // note, no space between "%s" and "&".

Let's do Windows in a subsequent CL.

[r, 2013-04-15 18:45:16]

LGTM

[bradfitz, 2013-04-15 18:50:17]

*** Submitted as https://code.google.com/p/go/source/detail?r=131549887d7c ***

test/stress: start of a runtime stress program

Runs forever, stressing the runtime in various ways.

It should never terminate.

R=golang-dev, r, minux.ma
CC=golang-dev
https://codereview.appspot.com/8583047