|
Make tests more reliable
- When an app is instantiated, always make the connection a no-op if possible to prevent unnecessary additional postponed calls.
- When an app is instantiated, always set the view to a no-op view to prevent routing.
Those two fixes prevent intermittent errors that have been showing up on CI and killing our runs when Canonistack isn't doing that for us.
- Change the compressed file to be called modules.js. This contains all of the modules, rather than pointing to them, as it does in devel/debug. This makes our tests pass in individual suites now.
https://code.launchpad.net/~gary/juju-gui/testclean/+merge/157941
(do not edit description out of merge proposal)
Total comments: 1
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+74 lines, -31 lines) |
Patch |
 |
M |
Makefile
|
View
|
|
8 chunks |
+20 lines, -10 lines |
0 comments
|
Download
|
 |
A |
[revision details]
|
View
|
|
1 chunk |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
app/app.js
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
 |
M |
app/modules-prod.js
|
View
|
|
1 chunk |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
app/store/charm.js
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
bin/merge-files
|
View
|
|
2 chunks |
+1 line, -2 lines |
0 comments
|
Download
|
 |
M |
test/index.html
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
test/test_app.js
|
View
|
|
17 chunks |
+37 lines, -10 lines |
0 comments
|
Download
|
 |
M |
test/test_app_hotkeys.js
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
test/test_application_notifications.js
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
test/test_endpoints.js
|
View
|
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
 |
M |
test/test_notifications.js
|
View
|
|
3 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
test/test_routing.js
|
View
|
|
1 chunk |
+2 lines, -1 line |
0 comments
|
Download
|
Total messages: 3
|