Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(793)

Issue 85770043: Noisy instance poller (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by wallyworld
Modified:
6 years, 5 months ago
Reviewers:
mp+214857, axw
Visibility:
Public.

Description

Noisy instance poller The instance poller was trying to poll instances which are not yet provisioned, creating lots of log noise. This fixes that. https://code.launchpad.net/~wallyworld/juju-core/instance-poller-noise/+merge/214857 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Noisy instance poller #

Patch Set 3 : Noisy instance poller #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -14 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M worker/instancepoller/machine_test.go View 1 7 chunks +29 lines, -9 lines 0 comments Download
M worker/instancepoller/updater.go View 1 2 5 chunks +20 lines, -5 lines 0 comments Download
M worker/instancepoller/updater_test.go View 1 2 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 5
wallyworld
Please take a look.
6 years, 5 months ago (2014-04-09 00:22:33 UTC) #1
axw
Yay, LGTM. Just one thought below... https://codereview.appspot.com/85770043/diff/1/worker/instancepoller/updater.go File worker/instancepoller/updater.go (right): https://codereview.appspot.com/85770043/diff/1/worker/instancepoller/updater.go#newcode188 worker/instancepoller/updater.go:188: machineStatus, _, _, ...
6 years, 5 months ago (2014-04-09 01:12:04 UTC) #2
wallyworld
Please take a look.
6 years, 5 months ago (2014-04-09 02:28:55 UTC) #3
wallyworld
On 2014/04/09 01:12:04, axw wrote: > Yay, LGTM. Just one thought below... > > https://codereview.appspot.com/85770043/diff/1/worker/instancepoller/updater.go ...
6 years, 5 months ago (2014-04-09 03:02:06 UTC) #4
wallyworld
6 years, 5 months ago (2014-04-09 03:09:25 UTC) #5
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b