Issue 85770043: Noisy instance poller

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 85770043: Noisy instance poller (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by wallyworld

Modified:
10 years ago

Reviewers:
mp+214857, axw

Visibility:
Public.

Description

Noisy instance poller The instance poller was trying to poll instances which are not yet provisioned, creating lots of log noise. This fixes that. https://code.launchpad.net/~wallyworld/juju-core/instance-poller-noise/+merge/214857 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Noisy instance poller #

Patch Set 3 : Noisy instance poller #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -14 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	worker/instancepoller/machine_test.go	View	1	7 chunks	+29 lines, -9 lines	0 comments	Download
M	worker/instancepoller/updater.go	View	1 2	5 chunks	+20 lines, -5 lines	0 comments	Download
M	worker/instancepoller/updater_test.go	View	1	2 chunks	+52 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

axw

Yay, LGTM. Just one thought below... https://codereview.appspot.com/85770043/diff/1/worker/instancepoller/updater.go File worker/instancepoller/updater.go (right): https://codereview.appspot.com/85770043/diff/1/worker/instancepoller/updater.go#newcode188 worker/instancepoller/updater.go:188: machineStatus, _, _, ...

10 years ago (2014-04-09 01:12:04 UTC) #2

wallyworld

On 2014/04/09 01:12:04, axw wrote: > Yay, LGTM. Just one thought below... > > https://codereview.appspot.com/85770043/diff/1/worker/instancepoller/updater.go ...

10 years ago (2014-04-09 03:02:06 UTC) #4

Please take a look.

Expand All Messages | Collapse All Messages