Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(809)

Issue 85750045: Force manual storage-port to int (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by wallyworld
Modified:
6 years, 5 months ago
Reviewers:
axw, mp+214866
Visibility:
Public.

Description

Force manual storage-port to int The manual provider storage-port config attribute needs to have a schema definition of ForceInt so it can be deserialised from state correctly. https://code.launchpad.net/~wallyworld/juju-core/manual-provider-storage-port-type/+merge/214866 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M provider/manual/config.go View 2 chunks +2 lines, -2 lines 0 comments Download
M provider/manual/config_test.go View 4 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 3
wallyworld
Please take a look.
6 years, 5 months ago (2014-04-09 01:22:19 UTC) #1
axw
On 2014/04/09 01:22:19, wallyworld wrote: > Please take a look. LGTM, thanks. How has this ...
6 years, 5 months ago (2014-04-09 01:23:34 UTC) #2
wallyworld
6 years, 5 months ago (2014-04-09 01:32:37 UTC) #3
On 2014/04/09 01:23:34, axw wrote:
> On 2014/04/09 01:22:19, wallyworld wrote:
> > Please take a look.
> 
> LGTM, thanks. How has this been working?

No idea :-)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b