Issue 8569043: code review 8569043: runtime: fix build on openbsd/386

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8569043: code review 8569043: runtime: fix build on openbsd/386 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by jsing

Modified:
12 years ago

Reviewers:

CC:
golang-dev, minux1, r

Visibility:
Public.

Description

runtime: fix build on openbsd/386

Patch Set 1 #

Patch Set 2 : diff -r 7767d71dcc7b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2a50b4f1d9f9 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/signal_openbsd_386.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

jsing

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-04-15 10:34:48 UTC) #1

minux1

We need openbsd/386 builder. Does all.bash pass on openbsd/386 with this patch?

12 years ago (2013-04-15 11:12:04 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=353a0bf40f71 *** runtime: fix build on openbsd/386 R=golang-dev, minux.ma, r CC=golang-dev https://codereview.appspot.com/8569043 ...

12 years ago (2013-04-15 17:20:27 UTC) #5

One step a time....

-rob

Expand All Messages | Collapse All Messages