Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3371)

Issue 8568044: state/api: add Constraints to AllWatcher

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by rog
Modified:
11 years ago
Reviewers:
mp+157875, dave, TheMue
Visibility:
Public.

Description

state/api: add Constraints to AllWatcher https://code.launchpad.net/~rogpeppe/juju-core/276-multiwatcher-constraints/+merge/157875 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/api: add Constraints to AllWatcher #

Patch Set 3 : state/api: add Constraints to AllWatcher #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -20 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M state/api/params/params.go View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M state/api/params/params_test.go View 1 2 3 chunks +8 lines, -6 lines 0 comments Download
M state/constraints.go View 2 chunks +10 lines, -6 lines 0 comments Download
M state/megawatcher.go View 1 2 5 chunks +55 lines, -1 line 0 comments Download
M state/megawatcher_internal_test.go View 1 2 4 chunks +54 lines, -3 lines 0 comments Download
M state/service.go View 1 2 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 4
rog
Please take a look.
11 years ago (2013-04-09 13:21:09 UTC) #1
TheMue
LGTM
11 years ago (2013-04-09 13:47:41 UTC) #2
dave_cheney.net
LGTM.
11 years ago (2013-04-10 02:55:07 UTC) #3
rog
11 years ago (2013-04-11 13:00:59 UTC) #4
*** Submitted:

state/api: add Constraints to AllWatcher

R=
CC=
https://codereview.appspot.com/8568044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b