Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(49)

Issue 8561048: Adds "popular" charms to sidebar.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by j.c.sackett
Modified:
11 years ago
Reviewers:
rharding, mp+158397, jeff.pihach
Visibility:
Public.

Description

Adds "popular" charms to sidebar. -Another block in sidebar creates the "popular" charm container. -"Popular" charms also added to cache. -"Popular" block added to sidebar template. -Added "popular" to sidebar json test data, and re-pretty-printed it. -Updated test for the additional charm in cache; although "popular" has two charms, one of them (cassandra) is also in our "new" category. https://code.launchpad.net/~jcsackett/juju-gui/add-new-to-sidebar/+merge/158397 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 8

Patch Set 2 : Adds "popular" charms to sidebar. #

Patch Set 3 : Adds "popular" charms to sidebar. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+865 lines, -261 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M app/subapps/browser/templates/sidebar.handlebars View 1 chunk +1 line, -0 lines 0 comments Download
M app/subapps/browser/views/sidebar.js View 3 chunks +20 lines, -1 line 0 comments Download
M test/data/sidebar_editorial.json View 1 1 chunk +841 lines, -259 lines 0 comments Download
M test/test_browser_app.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
j.c.sackett
Please take a look.
11 years ago (2013-04-11 15:14:04 UTC) #1
rharding
LGTM with comments below. https://codereview.appspot.com/8561048/diff/1/test-server.sh File test-server.sh (right): https://codereview.appspot.com/8561048/diff/1/test-server.sh#newcode8 test-server.sh:8: xdg-open http://0.0.0.0:8084/test/index.html please back out ...
11 years ago (2013-04-11 15:33:45 UTC) #2
j.c.sackett
https://codereview.appspot.com/8561048/diff/1/test-server.sh File test-server.sh (right): https://codereview.appspot.com/8561048/diff/1/test-server.sh#newcode8 test-server.sh:8: xdg-open http://0.0.0.0:8084/test/index.html On 2013/04/11 15:33:45, rharding wrote: > please ...
11 years ago (2013-04-11 15:52:26 UTC) #3
j.c.sackett
Please take a look.
11 years ago (2013-04-11 19:07:28 UTC) #4
jeff.pihach
LGTM thanks!
11 years ago (2013-04-11 19:11:15 UTC) #5
j.c.sackett
11 years ago (2013-04-11 19:25:16 UTC) #6
*** Submitted:

Adds "popular" charms to sidebar.

-Another block in sidebar creates the "popular" charm container.
-"Popular" charms also added to cache.
-"Popular" block added to sidebar template.
-Added "popular" to sidebar json test data, and re-pretty-printed it.
-Updated test for the additional charm in cache; although "popular" has two
charms, one of them (cassandra) is also in our "new" category.

R=rharding, jeff.pihach
CC=
https://codereview.appspot.com/8561048
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b