Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5468)

Issue 8551044: Update interfaces text for combo of req/provides

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by rharding
Modified:
11 years, 7 months ago
Reviewers:
mp+159669, curtis
Visibility:
Public.

Description

Update interfaces text for combo of req/provides - The text is different based on if there are 0, 1, or multiple provides and requires interfaces. https://code.launchpad.net/~rharding/juju-gui/interface-tab-intro/+merge/159669 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update interfaces text for combo of req/provides #

Patch Set 3 : Update interfaces text for combo of req/provides #

Unified diffs Side-by-side diffs Delta from patch set Stats (+291 lines, -22 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 1 chunk +31 lines, -18 lines 0 comments Download
M app/subapps/browser/views/charm.js View 2 chunks +56 lines, -0 lines 0 comments Download
M lib/views/browser/charm-full.less View 2 chunks +4 lines, -4 lines 0 comments Download
M test/test_browser_charm_details.js View 1 chunk +198 lines, -0 lines 0 comments Download

Messages

Total messages: 7
rharding
Please take a look.
11 years, 7 months ago (2013-04-18 19:10:00 UTC) #1
rharding
Please take a look.
11 years, 7 months ago (2013-04-18 19:16:48 UTC) #2
curtis
Hi Rick. I have a question about the layout. The function and tests are fine. ...
11 years, 7 months ago (2013-04-18 19:25:15 UTC) #3
rharding
reply below https://codereview.appspot.com/8551044/diff/1/app/subapps/browser/templates/browser_charm.handlebars File app/subapps/browser/templates/browser_charm.handlebars (right): https://codereview.appspot.com/8551044/diff/1/app/subapps/browser/templates/browser_charm.handlebars#newcode114 app/subapps/browser/templates/browser_charm.handlebars:114: <br /> On 2013/04/18 19:25:15, curtis wrote: ...
11 years, 7 months ago (2013-04-18 19:31:08 UTC) #4
curtis
Thank you for the explanation Rick. LGTM.
11 years, 7 months ago (2013-04-18 19:32:52 UTC) #5
rharding
LGTM
11 years, 7 months ago (2013-04-18 19:38:00 UTC) #6
rharding
11 years, 7 months ago (2013-04-18 19:46:06 UTC) #7
*** Submitted:

Update interfaces text for combo of req/provides

- The text is different based on if there are 0, 1, or multiple provides and
requires interfaces.

R=curtis
CC=
https://codereview.appspot.com/8551044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b