Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(627)

Issue 8547043: code review 8547043: net: add test for runtime.PollDesc leak (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by dfc
Modified:
10 years, 11 months ago
Reviewers:
CC:
bradfitz, golang-dev
Visibility:
Public.

Description

net: add test for runtime.PollDesc leak See 8318044

Patch Set 1 #

Patch Set 2 : diff -r 38bb920f0beb https://code.google.com/p/go #

Patch Set 3 : diff -r 38bb920f0beb https://code.google.com/p/go #

Patch Set 4 : diff -r 38bb920f0beb https://code.google.com/p/go #

Patch Set 5 : diff -r 38bb920f0beb https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M src/pkg/net/dial_test.go View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download

Messages

Total messages: 5
bradfitz
LGTM Update CL description to say the word "Issue" before the number ("Update Issue nnnnn") ...
10 years, 11 months ago (2013-04-09 01:03:12 UTC) #1
dfc
Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
10 years, 11 months ago (2013-04-09 01:08:50 UTC) #2
dfc
There is no issue number that I am aware of for this work. It probably ...
10 years, 11 months ago (2013-04-09 01:09:33 UTC) #3
bradfitz
LGTM On Apr 8, 2013 6:08 PM, <dave@cheney.net> wrote: > Reviewers: bradfitz, > > Message: ...
10 years, 11 months ago (2013-04-09 01:12:39 UTC) #4
dfc
10 years, 11 months ago (2013-04-09 01:14:33 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=72f34609fb25 ***

net: add test for runtime.PollDesc leak

See 8318044

R=bradfitz
CC=golang-dev
https://codereview.appspot.com/8547043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b