Issue 8542043: resolved support in sandbox/fakebackend

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8542043: resolved support in sandbox/fakebackend

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by bcsaller

Modified:
11 years, 6 months ago

Reviewers:
mp+157771, jeff.pihach, gary.poster

Visibility:
Public.

Description

resolved support in sandbox/fakebackend resolved is mostly a noop as fakebackend doesn't run hooks but this does a pass at validating inputs anyway. https://code.launchpad.net/~bcsaller/juju-gui/inmem-resolved/+merge/157771 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : resolved support in sandbox/fakebackend #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -4 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/store/env/fakebackend.js	View	1 chunk	+38 lines, -2 lines	0 comments	Download
M	app/store/env/sandbox.js	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	test/test_fakebackend.js	View	2 chunks	+22 lines, -2 lines	0 comments	Download
M	test/test_sandbox.js	View	1 chunk	+19 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bcsaller

11 years, 6 months ago (2013-04-09 04:38:21 UTC) #4

*** Submitted:

resolved support in sandbox/fakebackend

resolved is mostly a noop as fakebackend doesn't run hooks
but this does a pass at validating inputs anyway.

R=gary.poster, jeff.pihach
CC=
https://codereview.appspot.com/8542043

Expand All Messages | Collapse All Messages