Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(368)

Issue 85380043: state;api: Allow adding existing networks/NICs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by dimitern
Modified:
6 years, 5 months ago
Reviewers:
jameinel, mp+214712
Visibility:
Public.

Description

state;api: Allow adding existing networks/NICs Added an AlreadyExistsError in errors/ and in state/api/params with IsAlreadyExistsError and IsCodeAlreadyExists helpers. This is used in the provisioner API to report networks and interfaces that already exist, and is needed so that when provisioning more machines on the same network wont' lead to errors (trying to add existing network/NIC is just ignored). https://code.launchpad.net/~dimitern/juju-core/392-api-provisioner-allow-adding-existing-networks-nics/+merge/214712 Requires: https://code.launchpad.net/~dimitern/juju-core/391-maas-map-networks-to-macs/+merge/214592 (do not edit description out of merge proposal)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -35 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M errors/errors.go View 1 chunk +21 lines, -0 lines 0 comments Download
M errors/errors_test.go View 2 chunks +7 lines, -1 line 0 comments Download
M state/api/params/apierror.go View 2 chunks +5 lines, -0 lines 0 comments Download
M state/api/provisioner/machine.go View 2 chunks +5 lines, -2 lines 0 comments Download
M state/api/provisioner/provisioner.go View 2 chunks +5 lines, -2 lines 0 comments Download
M state/api/provisioner/provisioner_test.go View 6 chunks +13 lines, -11 lines 0 comments Download
M state/apiserver/common/errors.go View 1 chunk +2 lines, -0 lines 0 comments Download
M state/apiserver/common/errors_test.go View 1 chunk +4 lines, -0 lines 0 comments Download
M state/apiserver/provisioner/provisioner.go View 2 chunks +7 lines, -3 lines 0 comments Download
M state/apiserver/provisioner/provisioner_test.go View 2 chunks +2 lines, -7 lines 0 comments Download
M state/apiserver/testing/errors.go View 1 chunk +7 lines, -0 lines 0 comments Download
M state/machine.go View 2 chunks +10 lines, -4 lines 0 comments Download
M state/machine_test.go View 1 chunk +2 lines, -1 line 0 comments Download
M state/state.go View 2 chunks +9 lines, -3 lines 0 comments Download
M state/state_test.go View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2
dimitern
Please take a look.
6 years, 5 months ago (2014-04-08 10:27:20 UTC) #1
jameinel
6 years, 5 months ago (2014-04-08 14:00:05 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b