Issue 8533044: state/multiwatcher: add Store.Get

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8533044: state/multiwatcher: add Store.Get

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rog

Modified:
11 years ago

Reviewers:
mp+157764, frankban, TheMue

Visibility:
Public.

Description

state/multiwatcher: add Store.Get We need it so that we can update items conditionally. https://code.launchpad.net/~rogpeppe/juju-core/275-multiwatcher-get/+merge/157764 Requires: https://code.launchpad.net/~rogpeppe/juju-core/273-megawatcher-merge-attrs/+merge/157705 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/multiwatcher: add Store.Get #

Total comments: 2

Patch Set 3 : state/multiwatcher: add Store.Get #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -1 line)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/multiwatcher/multiwatcher.go	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
M	state/multiwatcher/multiwatcher_internal_test.go	View	1 2	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

TheMue

LGTM with one question. https://codereview.appspot.com/8533044/diff/2001/state/multiwatcher/multiwatcher.go File state/multiwatcher/multiwatcher.go (right): https://codereview.appspot.com/8533044/diff/2001/state/multiwatcher/multiwatcher.go#newcode431 state/multiwatcher/multiwatcher.go:431: // should not be changed. ...

11 years ago (2013-04-09 09:33:03 UTC) #2

rog

https://codereview.appspot.com/8533044/diff/2001/state/multiwatcher/multiwatcher.go File state/multiwatcher/multiwatcher.go (right): https://codereview.appspot.com/8533044/diff/2001/state/multiwatcher/multiwatcher.go#newcode431 state/multiwatcher/multiwatcher.go:431: // should not be changed. On 2013/04/09 09:33:03, TheMue ...

11 years ago (2013-04-09 10:13:06 UTC) #4

rog

11 years ago (2013-04-09 10:15:54 UTC) #5

*** Submitted:

state/multiwatcher: add Store.Get

We need it so that we can update items conditionally.

R=TheMue
CC=
https://codereview.appspot.com/8533044

Expand All Messages | Collapse All Messages