Issue 85240045: code review 85240045: goprotobuf: Remove never-used import of encoding/json i...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 85240045: code review 85240045: goprotobuf: Remove never-used import of encoding/json i... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 2 months ago by dsymonds

Modified:
10 years, 2 months ago

Reviewers:
r

CC:
r, golang-codereviews

Visibility:
Public.

Description

goprotobuf: Remove never-used import of encoding/json in generated code. It used to be used for a MarshalJSON method on enum types, but we no longer generate them.

Patch Set 1 #

Patch Set 2 : diff -r 8af8443f6427 https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 8af8443f6427 https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 8af8443f6427 https://code.google.com/p/goprotobuf #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -21 lines)			Patch
M	proto/testdata/test.pb.go	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	protoc-gen-go/descriptor/descriptor.pb.go	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	protoc-gen-go/generator/generator.go	View	1	3 chunks	+2 lines, -6 lines	0 comments	Download
M	protoc-gen-go/plugin/plugin.pb.go	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	protoc-gen-go/testdata/my_test/test.pb.go	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	protoc-gen-go/testdata/my_test/test.pb.go.golden	View	1	1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

10 years, 2 months ago (2014-04-13 23:17:22 UTC) #1

dsymonds

10 years, 2 months ago (2014-04-13 23:53:07 UTC) #3

*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=6457ef5bb896 ***

goprotobuf: Remove never-used import of encoding/json in generated code.

It used to be used for a MarshalJSON method on enum types,
but we no longer generate them.

LGTM=r
R=r
CC=golang-codereviews
https://codereview.appspot.com/85240045

Expand All Messages | Collapse All Messages