Issue 8513043: Add in the 'useful links' side column.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 8513043: Add in the 'useful links' side column.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years ago by rharding

Modified:
11 years ago

Reviewers:
mp+157642, j.c.sackett, jeff.pihach

Visibility:
Public.

Description

Add in the 'useful links' side column. - Pull Huw's branch that adds the column. - Since the view/template is shared between fullscreen/sidebar views it needs to toggle on/off. - Add tests for the isFullscreen added to the template. https://code.launchpad.net/~rharding/juju-gui/useful-links-sidebar/+merge/157642 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add in the 'useful links' side column. #

Patch Set 3 : Add in the 'useful links' side column. #

Created: 11 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+259 lines, -176 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/templates/browser_charm.handlebars	View	1 2	1 chunk	+179 lines, -167 lines	0 comments	Download
M	app/subapps/browser/views/charm.js	View	1 2	1 chunk	+5 lines, -2 lines	0 comments	Download
M	app/subapps/browser/views/view.js	View	1 2	3 chunks	+24 lines, -3 lines	0 comments	Download
M	lib/views/browser/charm-full.less	View		4 chunks	+28 lines, -4 lines	0 comments	Download
M	lib/views/browser/main.less	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	test/test_browser_app.js	View	1 2	2 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

jeff.pihach

LGTM with trivial - although I would like to see that fullscreen check moved into ...

11 years ago (2013-04-08 14:32:17 UTC) #2

rharding

11 years ago (2013-04-08 15:51:42 UTC) #4

*** Submitted:

Add in the 'useful links' side column.

- Pull Huw's branch that adds the column.
- Since the view/template is shared between fullscreen/sidebar views it needs
to toggle on/off.
- Add tests for the isFullscreen added to the template.

R=jeff.pihach, j.c.sackett
CC=
https://codereview.appspot.com/8513043

Expand All Messages | Collapse All Messages