Issue 85100044: Fix nil pointer error during test setup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 85100044: Fix nil pointer error during test setup

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by dave

Modified:
10 years ago

Reviewers:
mp+214636, waigani, wallyworld

Visibility:
Public.

Description

Fix nil pointer error during test setup Now a missing mongod returns a much improved error ubuntu@winton-02:~/src/launchpad.net/juju-core$ go test ./worker/uniter --- FAIL: TestPackage (0.00 seconds) mgo.go:211: exec: "mongod": executable file not found in $PATH FAIL FAIL launchpad.net/juju-core/worker/uniter 0.509s https://code.launchpad.net/~dave-cheney/juju-core/fix-nil-pointer-if-mongo-missing/+merge/214636 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix nil pointer error during test setup #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	testing/mgo.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

waigani

10 years ago (2014-04-08 00:06:39 UTC) #4

On 2014/04/07 23:47:05, dfc wrote:
> Please take a look.

LGTM Thanks for the explanation. It helped me understand.

Expand All Messages | Collapse All Messages