Time signature before repeat bars at beginning of line; issue 828

Time signature before repeat bars at beginning of line; issue 828

[lemzwerg, 2013-04-08 06:35:48]

LGTM.  Do we have a regtest for this?

[Keith, 2013-04-08 17:13:57]

On 2013/04/08 06:35:48, lemzwerg wrote:
> LGTM.  Do we have a regtest for this?

Yes, because several tests already have repeat bars at the start of lines.  They
look noticeably odd before this patch, so I think they can serve to alert us if
this patch ever fails in the future.

[janek, 2013-04-13 14:21:17]

What if a non-repeat barline is placed after a break?  Do i understand correctly
that this patch will also place it after time sig, and is this what we want?

Janek

[Keith, 2013-04-14 16:52:59]

On Sat, 13 Apr 2013 07:21:17 -0700, <janek.lilypond@gmail.com> wrote:

> What if a non-repeat barline is placed after a break?  Do i understand
> correctly that this patch will also place it after time sig, and is this
> what we want?
>

Yes it would place the bar-line after the time signature.  The only bar-lines at
the beginning of a line are repeats, and the similar segno:
   { b4 b b b \break \time 2/2 \key d\major
     \bar "S" b b b b }
We want the double bar before the key-change and time-signature at the end of
the line, and the § after the prefatory matter on the next line (and get this
after the patch).

[janek, 2013-04-14 17:08:58]

LGTM then.
thanks,
Janek

[janek, 2013-04-14 17:10:08]

On 2013/04/14 17:08:58, janek wrote:
> LGTM then.
> thanks,
> Janek

PS it may be worth changing commit message so that it's obvious that not only
repeat bars behaviour should change.