code review 8507043: cmd/go: clarify what "pkg.test" means wrt the -c flag

cmd/go: clarify what "pkg.test" means wrt the -c flag

Fixes issue 5230.

[adg, 2013-04-08 05:38:59]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[bradfitz, 2013-04-08 05:47:54]

Think this is 6 days late.



On Sun, Apr 7, 2013 at 10:39 PM, <adg@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/go: clarify what "pkg.test" means wrt the -c flag
>
> Fixes issue 5230.
>
> Please review this at
https://codereview.appspot.**com/8507043/<https://codereview.appspot.com/8507...
>
> Affected files:
>   M src/cmd/go/doc.go
>   M src/cmd/go/test.go
>
>
> Index: src/cmd/go/doc.go
> ==============================**==============================**=======
> --- a/src/cmd/go/doc.go
> +++ b/src/cmd/go/doc.go
> @@ -23,6 +23,7 @@
>      get         download and install packages and dependencies
>      install     compile and install packages and dependencies
>      list        list packages
> +    mock        mock packages
>      run         compile and run Go program
>      test        test packages
>      tool        run specified go tool
> @@ -363,6 +364,17 @@
>  For more about specifying packages, see 'go help packages'.
>
>
> +Mock packages
> +
> +Usage:
> +
> +       go mock [-x] [packages]
> +
> +Mock ridicules the packages named by the import paths.
> +
> +The -x flag enables explicit insults.
> +
> +
>  Compile and run Go program
>
>  Usage:
> @@ -410,6 +422,7 @@
>  In addition to the build flags, the flags handled by 'go test' itself are:
>
>         -c  Compile the test binary to pkg.test but do not run it.
> +           (Where pkg is the last element of the package's import path.)
>
>         -i
>             Install packages that are dependencies of the test.
> Index: src/cmd/go/test.go
> ==============================**==============================**=======
> --- a/src/cmd/go/test.go
> +++ b/src/cmd/go/test.go
> @@ -62,6 +62,7 @@
>  In addition to the build flags, the flags handled by 'go test' itself are:
>
>         -c  Compile the test binary to pkg.test but do not run it.
> +           (Where pkg is the last element of the package's import path.)
>
>         -i
>             Install packages that are dependencies of the test.
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[adg, 2013-04-08 05:51:43]

On 8 April 2013 15:47, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> Think this is 6 days late.
>

My bad, I forgot to revert my unfinished joke.

[bradfitz, 2013-04-08 05:54:37]

LGTM



On Sun, Apr 7, 2013 at 10:39 PM, <adg@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> cmd/go: clarify what "pkg.test" means wrt the -c flag
>
> Fixes issue 5230.
>
> Please review this at
https://codereview.appspot.**com/8507043/<https://codereview.appspot.com/8507...
>
> Affected files:
>   M src/cmd/go/doc.go
>   M src/cmd/go/test.go
>
>
> Index: src/cmd/go/doc.go
> ==============================**==============================**=======
> --- a/src/cmd/go/doc.go
> +++ b/src/cmd/go/doc.go
> @@ -23,6 +23,7 @@
>      get         download and install packages and dependencies
>      install     compile and install packages and dependencies
>      list        list packages
> +    mock        mock packages
>      run         compile and run Go program
>      test        test packages
>      tool        run specified go tool
> @@ -363,6 +364,17 @@
>  For more about specifying packages, see 'go help packages'.
>
>
> +Mock packages
> +
> +Usage:
> +
> +       go mock [-x] [packages]
> +
> +Mock ridicules the packages named by the import paths.
> +
> +The -x flag enables explicit insults.
> +
> +
>  Compile and run Go program
>
>  Usage:
> @@ -410,6 +422,7 @@
>  In addition to the build flags, the flags handled by 'go test' itself are:
>
>         -c  Compile the test binary to pkg.test but do not run it.
> +           (Where pkg is the last element of the package's import path.)
>
>         -i
>             Install packages that are dependencies of the test.
> Index: src/cmd/go/test.go
> ==============================**==============================**=======
> --- a/src/cmd/go/test.go
> +++ b/src/cmd/go/test.go
> @@ -62,6 +62,7 @@
>  In addition to the build flags, the flags handled by 'go test' itself are:
>
>         -c  Compile the test binary to pkg.test but do not run it.
> +           (Where pkg is the last element of the package's import path.)
>
>         -i
>             Install packages that are dependencies of the test.
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[adg, 2013-04-08 06:03:29]

*** Submitted as https://code.google.com/p/go/source/detail?r=554abd8364c6 ***

cmd/go: clarify what "pkg.test" means wrt the -c flag

Fixes issue 5230.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/8507043