code review 85040044: cmd/gc: fewer errors for wrong argument count

cmd/gc: fewer errors for wrong argument count

Fixes issue 7675

[atom, 2014-04-07 19:29:46]

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2014-04-08 18:59:15]

https://codereview.appspot.com/85040044/diff/30001/src/cmd/gc/typecheck.c
File src/cmd/gc/typecheck.c (right):

https://codereview.appspot.com/85040044/diff/30001/src/cmd/gc/typecheck.c#new...
src/cmd/gc/typecheck.c:2188: tn = n->type->type;
how about adding

static int
hasddd(Type *t)
{
}

and then this can be

if(!hasddd(tstruct)) {
    n1 = structcount(tstruct);
    n2 = structcount(n->type->type);
    if(n1 < n2)
        goto notenough;
    if(n1 > n2)
        goto toomany;
}

and then the same below. there's no need for the countok1 and countok2 labels
and it should be a little clearer.

[atom, 2014-04-09 09:31:38]

https://codereview.appspot.com/85040044/diff/30001/src/cmd/gc/typecheck.c
File src/cmd/gc/typecheck.c (right):

https://codereview.appspot.com/85040044/diff/30001/src/cmd/gc/typecheck.c#new...
src/cmd/gc/typecheck.c:2188: tn = n->type->type;
On 2014/04/08 18:59:15, rsc wrote:
> how about adding
> 
> static int
> hasddd(Type *t)
> {
> }
> 
> and then this can be
> 
> if(!hasddd(tstruct)) {
>     n1 = structcount(tstruct);
>     n2 = structcount(n->type->type);
>     if(n1 < n2)
>         goto notenough;
>     if(n1 > n2)
>         goto toomany;
> }
> 
> and then the same below. there's no need for the countok1 and countok2 labels
> and it should be a little clearer.

Done.

[rsc, 2014-04-17 02:31:32]

LGTM

[rsc, 2014-04-17 02:42:13]

*** Submitted as https://code.google.com/p/go/source/detail?r=01b16f024b7b ***

cmd/gc: fewer errors for wrong argument count

Fixes issue 7675

LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/85040044

Committer: Russ Cox <rsc@golang.org>

[gobot, 2014-04-17 07:17:30]

This CL appears to have broken the linux-386-387 builder.
See http://build.golang.org/log/06f3bdc861e85a9f9f644e830261e9326b88e0ec