Issue 85020043: Use AsyncDocIdPusher to push named resources

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 85020043: Use AsyncDocIdPusher to push named resources (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by Tanmay Vartak

Modified:
10 years ago

Reviewers:
pjo

CC:
connector-cr_google.com

Visibility:
Public.

More Reviews

Description

Use AsyncDocIdPusher to push named resources

Patch Set 2 : With missing file AccumulatingAsyncDocIdPusher.java from initial patch #

Total comments: 2

Patch Set 3 : With code review comments implemented #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -13 lines)			Patch
M	src/com/google/enterprise/adaptor/sharepoint/SharePointAdaptor.java	View		1 chunk	+3 lines, -12 lines	0 comments	Download
A	test/com/google/enterprise/adaptor/sharepoint/AccumulatingAsyncDocIdPusher.java	View	1 2	1 chunk	+66 lines, -0 lines	0 comments	Download
M	test/com/google/enterprise/adaptor/sharepoint/MockAdaptorContext.java	View		3 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

pjo

Thank you. https://codereview.appspot.com/85020043/diff/20001/test/com/google/enterprise/adaptor/sharepoint/AccumulatingAsyncDocIdPusher.java File test/com/google/enterprise/adaptor/sharepoint/AccumulatingAsyncDocIdPusher.java (right): https://codereview.appspot.com/85020043/diff/20001/test/com/google/enterprise/adaptor/sharepoint/AccumulatingAsyncDocIdPusher.java#newcode28 test/com/google/enterprise/adaptor/sharepoint/AccumulatingAsyncDocIdPusher.java:28: this.pusher = pusher; check not null? https://codereview.appspot.com/85020043/diff/20001/test/com/google/enterprise/adaptor/sharepoint/AccumulatingAsyncDocIdPusher.java#newcode35 ...

10 years ago (2014-04-07 23:23:55 UTC) #3

LGTM.  Thank you.

Expand All Messages | Collapse All Messages