Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(7982)

Issue 8500043: Fix the broken bzr test.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by thumper
Modified:
11 years ago
Reviewers:
mp+157566, dave
Visibility:
Public.

Description

Fix the broken bzr test. The TestCommit test in bzr/bzr_test.go assumes that the revision-id is shown in the log output. This is only the case if log has been aliased to include the --show-ids flag. This fix explicitly puts that option in the bzr command to be executed. https://code.launchpad.net/~thumper/juju-core/fix-bzr-test/+merge/157566 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix the broken bzr test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M bzr/bzr_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
thumper
Please take a look.
11 years ago (2013-04-07 22:29:03 UTC) #1
dave_cheney.net
LGTM. Thank you
11 years ago (2013-04-07 23:49:35 UTC) #2
thumper
11 years ago (2013-04-07 23:51:38 UTC) #3
*** Submitted:

Fix the broken bzr test.

The TestCommit test in bzr/bzr_test.go assumes that the revision-id is shown
in the log output.  This is only the case if log has been aliased to include
the --show-ids flag.  This fix explicitly puts that option in the bzr command
to be executed.

R=dfc
CC=
https://codereview.appspot.com/8500043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b