Support clicking tokens to open charm details.

Support clicking tokens to open charm details.

- Fixes bug in slider that missed cleaning up a timer created.
- Add sample data from the Charmworld0 store api for tests.
- Make sure that we catch charm token clicks
- Refactor the charm details opening to be just the details so we can
retrigger
- Cache model instances so that we don't need to re-fetch the model data in
details views

https://code.launchpad.net/~rharding/juju-gui/sidebar_details/+merge/157528

(do not edit description out of merge proposal)

[rharding, 2013-04-07 19:13:27]

Please take a look.

[jeff.pihach, 2013-04-08 14:10:11]

LGTM nice catch on the left over timer.

https://codereview.appspot.com/8488043/diff/1/app/subapps/browser/views/sideb...
File app/subapps/browser/views/sidebar.js (right):

https://codereview.appspot.com/8488043/diff/1/app/subapps/browser/views/sideb...
app/subapps/browser/views/sidebar.js:75: var id =
ev.currentTarget.getAttribute('data-charmid');
Just FYI there is a Node.getData() method which you can use ehre.
http://yuilibrary.com/yui/docs/api/classes/Node.html#method_getData

https://codereview.appspot.com/8488043/diff/1/app/widgets/charm-slider.js
File app/widgets/charm-slider.js (right):

https://codereview.appspot.com/8488043/diff/1/app/widgets/charm-slider.js#new...
app/widgets/charm-slider.js:200: this.get('timer').cancel();
nice catch

https://codereview.appspot.com/8488043/diff/1/test/test_browser_app.js
File test/test_browser_app.js (right):

https://codereview.appspot.com/8488043/diff/1/test/test_browser_app.js#newcod...
test/test_browser_app.js:148: var sample_data =
Y.io('data/sidebar_editorial.json', {sync: true});
Maybe this should be loaded in the before() and then just referenced from there
as I don't think this is modified?

[rharding, 2013-04-08 14:27:33]

Please take a look.

[j.c.sackett, 2013-04-08 15:09:47]

LGTM, thanks Rick.

https://codereview.appspot.com/8488043/diff/7001/app/subapps/browser/views/ch...
File app/subapps/browser/views/charm.js (right):

https://codereview.appspot.com/8488043/diff/7001/app/subapps/browser/views/ch...
app/subapps/browser/views/charm.js:76: scores[categoryName][questionIndex]) {
At this point is this really better than Y.Lang.isValue? My understanding is
that it handles all the chaining to determine if a value exists, rather than if
(a && a.b).

https://codereview.appspot.com/8488043/diff/7001/test/test_browser_charm_deta...
File test/test_browser_charm_details.js (right):

https://codereview.appspot.com/8488043/diff/7001/test/test_browser_charm_deta...
test/test_browser_charm_details.js:271: it('does not blow up when the scores
from the api is null', function() {
Got to love that test description. :-P

[rharding, 2013-04-08 15:27:40]

*** Submitted:

Support clicking tokens to open charm details.

- Fixes bug in slider that missed cleaning up a timer created.
- Add sample data from the Charmworld0 store api for tests.
- Make sure that we catch charm token clicks
- Refactor the charm details opening to be just the details so we can
retrigger
- Cache model instances so that we don't need to re-fetch the model data in
details views

R=jeff.pihach, j.c.sackett
CC=
https://codereview.appspot.com/8488043