Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(163)

Issue 84830043: code review 84830043: syscall: fix Getfsstat() for BSD

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by pcj
Modified:
6 years, 9 months ago
Reviewers:
gobot, adg, mikio
CC:
golang-codereviews, mikio, adg
Visibility:
Public.

Description

syscall: fix Getfsstat() for BSD The buffer length should be the size in bytes instead of the number of structs. Fixes issue 6588.

Patch Set 1 #

Patch Set 2 : diff -r 88b3b2fa4dde https://code.google.com/p/go #

Patch Set 3 : diff -r 88b3b2fa4dde https://code.google.com/p/go #

Patch Set 4 : diff -r 519230b4d06a https://code.google.com/p/go #

Total comments: 4

Patch Set 5 : diff -r 519230b4d06a https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -157 lines) Patch
A src/pkg/syscall/syscall_bsd_test.go View 1 2 3 4 1 chunk +34 lines, -0 lines 0 comments Download
M src/pkg/syscall/syscall_darwin.go View 1 2 chunks +15 lines, -1 line 0 comments Download
M src/pkg/syscall/syscall_dragonfly.go View 1 2 chunks +15 lines, -1 line 0 comments Download
M src/pkg/syscall/syscall_freebsd.go View 1 2 chunks +15 lines, -1 line 0 comments Download
M src/pkg/syscall/syscall_openbsd.go View 1 2 chunks +15 lines, -1 line 0 comments Download
M src/pkg/syscall/zsyscall_darwin_386.go View 1 1 chunk +0 lines, -17 lines 0 comments Download
M src/pkg/syscall/zsyscall_darwin_amd64.go View 1 1 chunk +0 lines, -17 lines 0 comments Download
M src/pkg/syscall/zsyscall_dragonfly_386.go View 1 1 chunk +0 lines, -17 lines 0 comments Download
M src/pkg/syscall/zsyscall_dragonfly_amd64.go View 1 1 chunk +0 lines, -17 lines 0 comments Download
M src/pkg/syscall/zsyscall_freebsd_386.go View 1 1 chunk +0 lines, -17 lines 0 comments Download
M src/pkg/syscall/zsyscall_freebsd_amd64.go View 1 1 chunk +0 lines, -17 lines 0 comments Download
M src/pkg/syscall/zsyscall_freebsd_arm.go View 1 1 chunk +0 lines, -17 lines 0 comments Download
M src/pkg/syscall/zsyscall_openbsd_386.go View 1 1 chunk +0 lines, -17 lines 0 comments Download
M src/pkg/syscall/zsyscall_openbsd_amd64.go View 1 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 9
pcj
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
6 years, 9 months ago (2014-04-05 18:10:53 UTC) #1
mikio
please add a new test case for Getfsstat into the new file syscall_bsd_test.go, thanks.
6 years, 9 months ago (2014-04-07 00:00:19 UTC) #2
pcj
Hello golang-codereviews@googlegroups.com, mikioh.mikioh@gmail.com (cc: golang-codereviews@googlegroups.com), Please take another look.
6 years, 9 months ago (2014-04-07 00:36:20 UTC) #3
mikio
Please see http://golang.org/doc/contribute.html#copyright and proceed the process w/ project owner's help. https://codereview.appspot.com/84830043/diff/60001/src/pkg/syscall/syscall_bsd_test.go File src/pkg/syscall/syscall_bsd_test.go (right): ...
6 years, 9 months ago (2014-04-07 01:01:54 UTC) #4
pcj
Hello golang-codereviews@googlegroups.com, mikioh.mikioh@gmail.com (cc: golang-codereviews@googlegroups.com), Please take another look.
6 years, 9 months ago (2014-04-07 01:18:44 UTC) #5
mikio
LGTM adg: could you please help him for signing off?
6 years, 9 months ago (2014-04-07 02:08:14 UTC) #6
adg
On 7 April 2014 12:08, Mikio Hara <mikioh.mikioh@gmail.com> wrote: > adg: could you please help ...
6 years, 9 months ago (2014-04-07 02:10:33 UTC) #7
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=6c4e0c99f534 *** syscall: fix Getfsstat() for BSD The buffer length should be ...
6 years, 9 months ago (2014-04-10 03:58:10 UTC) #8
gobot
6 years, 9 months ago (2014-04-10 07:54:06 UTC) #9
This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/96fedbf1789e282ac86669e47a6aabdee11e1f3b
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b