code review 84830043: syscall: fix Getfsstat() for BSD

syscall: fix Getfsstat() for BSD

The buffer length should be the size in bytes
instead of the number of structs.

Fixes issue 6588.

[pcj, 2014-04-05 18:10:53]

Hello golang-codereviews@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[mikio, 2014-04-07 00:00:19]

please add a new test case for Getfsstat into the new file syscall_bsd_test.go,
thanks.

[pcj, 2014-04-07 00:36:20]

Hello golang-codereviews@googlegroups.com, mikioh.mikioh@gmail.com (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[mikio, 2014-04-07 01:01:54]

Please see http://golang.org/doc/contribute.html#copyright and proceed the
process w/ project owner's help.

https://codereview.appspot.com/84830043/diff/60001/src/pkg/syscall/syscall_bs...
File src/pkg/syscall/syscall_bsd_test.go (right):

https://codereview.appspot.com/84830043/diff/60001/src/pkg/syscall/syscall_bs...
src/pkg/syscall/syscall_bsd_test.go:5: // +build freebsd dragonfly darwin
openbsd
alphanumeric order pls

https://codereview.appspot.com/84830043/diff/60001/src/pkg/syscall/syscall_bs...
src/pkg/syscall/syscall_bsd_test.go:15: n, err := syscall.Getfsstat(nil, 1 /*
MNT_WAIT */)
const MNT_WAIT = 1 is fine

https://codereview.appspot.com/84830043/diff/60001/src/pkg/syscall/syscall_bs...
src/pkg/syscall/syscall_bsd_test.go:17: t.Fatalf("Getfsstat: %v", err)
you can just write t.Fatal(err); i mean, looks like people loves a concise style
even in test cases recently.

https://codereview.appspot.com/84830043/diff/60001/src/pkg/syscall/syscall_bs...
src/pkg/syscall/syscall_bsd_test.go:29: t.Fatal("An empty Statfs_t struct was
returned.")
perhaps s/An/an/ because testing package will add a prefix appropriately.

[pcj, 2014-04-07 01:18:44]

Hello golang-codereviews@googlegroups.com, mikioh.mikioh@gmail.com (cc:
golang-codereviews@googlegroups.com),

Please take another look.

[mikio, 2014-04-07 02:08:14]

LGTM

adg: could you please help him for signing off?

[adg, 2014-04-07 02:10:33]

On 7 April 2014 12:08, Mikio Hara <mikioh.mikioh@gmail.com> wrote:

> adg: could you please help him for signing off?


Yep already on it.

[adg, 2014-04-10 03:58:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=6c4e0c99f534 ***

syscall: fix Getfsstat() for BSD

The buffer length should be the size in bytes
instead of the number of structs.

Fixes issue 6588.

LGTM=mikioh.mikioh
R=golang-codereviews, mikioh.mikioh, adg
CC=golang-codereviews
https://codereview.appspot.com/84830043

Committer: Andrew Gerrand <adg@golang.org>

[gobot, 2014-04-10 07:54:06]

This CL appears to have broken the openbsd-386-rootbsd builder.
See http://build.golang.org/log/96fedbf1789e282ac86669e47a6aabdee11e1f3b