Issue 84680044: Some spring cleaning mostly concerning cumbersome apply calls

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 84680044: Some spring cleaning mostly concerning cumbersome apply calls (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by dak

Modified:
8 years, 9 months ago

Reviewers:
Devon Schudy

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Some spring cleaning mostly concerning cumbersome apply calls

Patch Set 2 : Replace a few more cases of (map ... (zip ...)) #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -20 lines)			Patch
M	scm/document-markup.scm	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	scm/lily.scm	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	scm/lily-library.scm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	scm/output-svg.scm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	scm/page.scm	View	1	1 chunk	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Devon Schudy

LGTM. https://codereview.appspot.com/84680044/diff/1/scm/lily.scm File scm/lily.scm (left): https://codereview.appspot.com/84680044/diff/1/scm/lily.scm#oldcode753 scm/lily.scm:753: (diff (map (lambda (y) (apply - y)) (zip ...

10 years ago (2014-04-06 04:01:45 UTC) #1

Replace a few more cases of (map ... (zip ...))

Expand All Messages | Collapse All Messages