Issue 84650047: code review 84650047: os/signal: use unique program name during TestCtrlBreak

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 84650047: code review 84650047: os/signal: use unique program name during TestCtrlBreak (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by brainman

Modified:
11 years, 2 months ago

Reviewers:
gobot, bradfitz

CC:
golang-codereviews, bradfitz

Visibility:
Public.

Description

os/signal: use unique program name during TestCtrlBreak

Patch Set 2 : diff -r f5ef7ec5b144 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f5ef7ec5b144 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f5ef7ec5b144 https://go.googlecode.com/hg/ #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	src/pkg/os/signal/signal_windows_test.go	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

brainman

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 2 months ago (2014-04-11 06:40:23 UTC) #1

brainman

This change is because windows-amd64-race builder crashes http://build.golang.org/log/2739e5425f33ec233427501024b763e7309ee182 with --- FAIL: TestCtrlBreak (0.55 seconds) signal_windows_test.go:73: ...

11 years, 2 months ago (2014-04-11 06:40:49 UTC) #2

bradfitz

LGTM On Thu, Apr 10, 2014 at 11:40 PM, <alex.brainman@gmail.com> wrote: > This change is ...

11 years, 2 months ago (2014-04-11 06:41:35 UTC) #3

brainman

*** Submitted as https://code.google.com/p/go/source/detail?r=04ab9968c31b *** os/signal: use unique program name during TestCtrlBreak LGTM=bradfitz R=golang-codereviews, bradfitz ...

11 years, 2 months ago (2014-04-11 06:43:46 UTC) #4

gobot

11 years, 2 months ago (2014-04-11 07:07:44 UTC) #5

Message was sent while issue was closed.

This CL appears to have broken the openbsd-amd64-rootbsd builder.
See http://build.golang.org/log/65cb0168d3e32861b4eacfbad9a54fad6521baa9

Expand All Messages | Collapse All Messages