Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(504)

Issue 84570045: code review 84570045: cmd/8g: fix liveness for 387 build (including plan9) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by rsc
Modified:
11 years, 2 months ago
Reviewers:
gobot, dave
CC:
khr, golang-codereviews
Visibility:
Public.

Description

cmd/8g: fix liveness for 387 build (including plan9)

Patch Set 1 #

Patch Set 2 : diff -r b958fefe50a7 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b958fefe50a7 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M src/cmd/8g/prog.c View 1 1 chunk +10 lines, -5 lines 0 comments Download
M src/cmd/gc/plive.c View 1 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 4
rsc
Hello khr (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
11 years, 2 months ago (2014-04-06 14:30:11 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=519230b4d06a *** cmd/8g: fix liveness for 387 build (including plan9) TBR=khr CC=golang-codereviews ...
11 years, 2 months ago (2014-04-06 14:30:19 UTC) #2
gobot
This CL appears to have broken the linux-arm-cheney-imx6 builder. See http://build.golang.org/log/abb8ed3f18de098ed0562a518d660384de71b23e
11 years, 2 months ago (2014-04-07 03:14:15 UTC) #3
dave_cheney.net
11 years, 2 months ago (2014-04-07 03:20:10 UTC) #4
Not realy, sorry for the noise, having a few teething issues getting
this builder running.

On Mon, Apr 7, 2014 at 1:14 PM,  <gobot@golang.org> wrote:
> This CL appears to have broken the linux-arm-cheney-imx6 builder.
> See http://build.golang.org/log/abb8ed3f18de098ed0562a518d660384de71b23e
>
>
> https://codereview.appspot.com/84570045/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b