Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(751)

Issue 8456: Adding check on Replicated classes

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years ago by danny.antonetti
Modified:
7 years, 11 months ago
Reviewers:
max ross <max.ross, Max Ross
CC:
hibernate-shards-dev_googlegroups.com
Base URL:
http://anonsvn.jboss.org/repos/hibernate/shards/trunk/src/
Visibility:
Public.

Description

I have added code to check to make sure that there are no cascades from non-replicated entities to replicated entities.

Patch Set 1 #

Patch Set 2 : Updating with max's comments #

Patch Set 3 : updating with Max's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+569 lines, -177 lines) Patch
java/org/hibernate/shards/ShardedConfiguration.java View 1 2 4 chunks +47 lines, -0 lines 0 comments Download
java/org/hibernate/shards/strategy/selection/Replicated.java View 1 1 chunk +35 lines, -0 lines 0 comments Download
java/org/hibernate/shards/transaction/ShardedTransactionImpl.java View 1 chunk +2 lines, -0 lines 0 comments Download
java/org/hibernate/shards/util/Lists.java View 1 1 chunk +2 lines, -0 lines 0 comments Download
test/org/hibernate/shards/ShardedConfigurationReplicationTest.java View 1 1 chunk +33 lines, -72 lines 0 comments Download
test/org/hibernate/shards/integration/model/ModelCriteriaPermutedIntegrationTest.java View 1 4 chunks +12 lines, -0 lines 0 comments Download
test/org/hibernate/shards/integration/model/ModelDataFactory.java View 1 2 chunks +17 lines, -0 lines 0 comments Download
test/org/hibernate/shards/integration/platform/hsql/HSQLDatabasePlatform.java View 1 chunk +3 lines, -1 line 0 comments Download
test/org/hibernate/shards/integration/platform/hsql/config/mappings.hbm.xml View 1 chunk +3 lines, -101 lines 0 comments Download
test/org/hibernate/shards/integration/platform/hsql/config/shard0.hibernate.cfg.xml View 1 chunk +1 line, -1 line 0 comments Download
test/org/hibernate/shards/integration/platform/hsql/config/shard1.hibernate.cfg.xml View 1 chunk +1 line, -1 line 0 comments Download
test/org/hibernate/shards/integration/platform/hsql/config/shard2.hibernate.cfg.xml View 1 chunk +1 line, -1 line 0 comments Download
test/org/hibernate/shards/integration/platform/mysql/config/mappings.hbm.xml View 1 chunk +17 lines, -0 lines 0 comments Download
test/org/hibernate/shards/model/Building.java View 2 chunks +9 lines, -0 lines 0 comments Download
test/org/hibernate/shards/model/City.java View 1 1 chunk +59 lines, -0 lines 0 comments Download
test/org/hibernate/shards/model/State.java View 1 1 chunk +67 lines, -0 lines 0 comments Download
test/org/hibernate/shards/testmodel/replicationtest/NotReplicated.java View 1 1 chunk +56 lines, -0 lines 0 comments Download
test/org/hibernate/shards/testmodel/replicationtest/NotReplicated.hbm.xml View 1 chunk +11 lines, -0 lines 0 comments Download
test/org/hibernate/shards/testmodel/replicationtest/NotReplicatedBadCascade.java View 1 1 chunk +57 lines, -0 lines 0 comments Download
test/org/hibernate/shards/testmodel/replicationtest/NotReplicatedBadCascade.hbm.xml View 1 chunk +12 lines, -0 lines 0 comments Download
test/org/hibernate/shards/testmodel/replicationtest/Replicated1.java View 1 1 chunk +57 lines, -0 lines 0 comments Download
test/org/hibernate/shards/testmodel/replicationtest/Replicated1.hbm.xml View 1 chunk +12 lines, -0 lines 0 comments Download
test/org/hibernate/shards/testmodel/replicationtest/Replicated2.java View 1 1 chunk +44 lines, -0 lines 0 comments Download
test/org/hibernate/shards/testmodel/replicationtest/Replicated2.hbm.xml View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 3
danny.antonetti
Here are my changes to enable detection of bad cascades. Most of the change is ...
14 years ago (2008-11-10 16:07:07 UTC) #1
Max Ross
Great start Danny! Mostly style nits, but one big question: Is this CL supposed to ...
14 years ago (2008-11-16 21:58:47 UTC) #2
danny.antonetti
14 years ago (2008-11-30 02:18:25 UTC) #3
I have updated this change, fixing Max's comments.

This change performs a check to verify that there are no cascades from
Non-Replicated Entities to Replicated Entities.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b