Issue 84520047: Support the --ppa flag for distro packaging.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 84520047: Support the --ppa flag for distro packaging.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years ago by frankban

Modified:
10 years ago

Reviewers:
bac, mp+214536

Visibility:
Public.

Description

Support the --ppa flag for distro packaging. Add a packaging module suitable for being easily modified when packaging quickstart for distro repositories. The new --ppa flag can be used to switch to ppa when quickstart is installed from the default repositories. Tests: `make check`. QA: there is no easy way to QA this. It would require removing juju packages, running quickstart with and without the --distro-only and --ppa flags, switching packaging.py to "distro" and trying again. I'll do that anyway as part of the next release QA, so feel free to avoid QAing now. https://code.launchpad.net/~frankban/juju-quickstart/ppa-flag/+merge/214536 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Support the --ppa flag for distro packaging. #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -2 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	quickstart/__init__.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	quickstart/manage.py	View	1	4 chunks	+31 lines, -1 line	0 comments	Download
A	quickstart/packaging.py	View		1 chunk	+31 lines, -0 lines	0 comments	Download
M	quickstart/tests/test_manage.py	View		1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bac

LGTM https://codereview.appspot.com/84520047/diff/1/quickstart/manage.py File quickstart/manage.py (right): https://codereview.appspot.com/84520047/diff/1/quickstart/manage.py#newcode76 quickstart/manage.py:76: ppa_help += '\n(enabled by default, use --distro-only to ...

10 years ago (2014-04-07 14:46:32 UTC) #2

frankban

*** Submitted: Support the --ppa flag for distro packaging. Add a packaging module suitable for ...

10 years ago (2014-04-07 15:55:19 UTC) #3

Thank you Brad!

Expand All Messages | Collapse All Messages